From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVi4h-0008Q4-Bx for qemu-devel@nongnu.org; Fri, 26 Apr 2013 08:48:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVi4f-0005ka-No for qemu-devel@nongnu.org; Fri, 26 Apr 2013 08:48:27 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:52419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVi4f-0005kA-6S for qemu-devel@nongnu.org; Fri, 26 Apr 2013 08:48:25 -0400 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Apr 2013 22:40:20 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id C7CA7357804A for ; Fri, 26 Apr 2013 22:48:13 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3QCYZ8l22937684 for ; Fri, 26 Apr 2013 22:34:36 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3QCmC13021548 for ; Fri, 26 Apr 2013 22:48:12 +1000 From: Anthony Liguori In-Reply-To: <1366975466-21509-2-git-send-email-kraxel@redhat.com> References: <1366975466-21509-1-git-send-email-kraxel@redhat.com> <1366975466-21509-2-git-send-email-kraxel@redhat.com> Date: Fri, 26 Apr 2013 07:47:54 -0500 Message-ID: <87ehdxjw5h.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/2] gtk: fix cursor unref List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Gerd Hoffmann writes: > Use correct unref function, cursors are not gobjects (at least in gtk2). > Fixes crash, reproducer: "qemu -vga qxl -display gtk". > > Signed-off-by: Gerd Hoffmann Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > ui/gtk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ui/gtk.c b/ui/gtk.c > index 42e3c0a..71fda24 100644 > --- a/ui/gtk.c > +++ b/ui/gtk.c > @@ -359,7 +359,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl, > pixbuf, c->hot_x, c->hot_y); > gdk_window_set_cursor(gtk_widget_get_window(s->drawing_area), cursor); > g_object_unref(pixbuf); > - g_object_unref(cursor); > + gdk_cursor_unref(cursor); > } > > static void gd_switch(DisplayChangeListener *dcl, > -- > 1.7.9.7