From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46665)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TdpKh-00057G-CJ
	for qemu-devel@nongnu.org; Wed, 28 Nov 2012 16:38:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TdpKg-0001ZE-1I
	for qemu-devel@nongnu.org; Wed, 28 Nov 2012 16:38:15 -0500
Received: from e28smtp08.in.ibm.com ([122.248.162.8]:42448)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TdpKf-0001XF-Fx
	for qemu-devel@nongnu.org; Wed, 28 Nov 2012 16:38:13 -0500
Received: from /spool/local
	by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Thu, 29 Nov 2012 03:07:46 +0530
Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66])
	by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	qASLbhjS6488360
	for <qemu-devel@nongnu.org>; Thu, 29 Nov 2012 03:07:44 +0530
Received: from d28av04.in.ibm.com (loopback [127.0.0.1])
	by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	qAT37YA8005240
	for <qemu-devel@nongnu.org>; Thu, 29 Nov 2012 14:07:34 +1100
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <50AE835B.1020706@siemens.com>
References: <50AE835B.1020706@siemens.com>
Date: Wed, 28 Nov 2012 15:37:38 -0600
Message-ID: <87ehjds925.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] event notifier: Fix setup for win32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

Jan Kiszka <jan.kiszka@siemens.com> writes:

> The event notifier state is only reset by test_and_clear. But we created
> the windows event object with auto-reset, which subtly swallowed events.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Applied. Thanks.

Regards,

Anthony Liguori

> ---
>
> Grr, the last place I looked at after hours of debugging...
>
>  event_notifier-win32.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/event_notifier-win32.c b/event_notifier-win32.c
> index c723dad..4ed21c2 100644
> --- a/event_notifier-win32.c
> +++ b/event_notifier-win32.c
> @@ -16,7 +16,7 @@
>  
>  int event_notifier_init(EventNotifier *e, int active)
>  {
> -    e->event = CreateEvent(NULL, FALSE, FALSE, NULL);
> +    e->event = CreateEvent(NULL, TRUE, FALSE, NULL);
>      assert(e->event);
>      return 0;
>  }
> -- 
> 1.7.3.4