* [Qemu-devel] [PATCH] event notifier: Fix setup for win32
@ 2012-11-22 19:56 Jan Kiszka
2012-11-23 7:08 ` Stefan Hajnoczi
2012-11-28 21:37 ` [Qemu-devel] [PATCH] " Anthony Liguori
0 siblings, 2 replies; 4+ messages in thread
From: Jan Kiszka @ 2012-11-22 19:56 UTC (permalink / raw)
To: Anthony Liguori, qemu-devel; +Cc: Paolo Bonzini, Stefan Hajnoczi
The event notifier state is only reset by test_and_clear. But we created
the windows event object with auto-reset, which subtly swallowed events.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Grr, the last place I looked at after hours of debugging...
event_notifier-win32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/event_notifier-win32.c b/event_notifier-win32.c
index c723dad..4ed21c2 100644
--- a/event_notifier-win32.c
+++ b/event_notifier-win32.c
@@ -16,7 +16,7 @@
int event_notifier_init(EventNotifier *e, int active)
{
- e->event = CreateEvent(NULL, FALSE, FALSE, NULL);
+ e->event = CreateEvent(NULL, TRUE, FALSE, NULL);
assert(e->event);
return 0;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] event notifier: Fix setup for win32
2012-11-22 19:56 [Qemu-devel] [PATCH] event notifier: Fix setup for win32 Jan Kiszka
@ 2012-11-23 7:08 ` Stefan Hajnoczi
2012-11-28 11:40 ` [Qemu-devel] [PATCH 1.3] " Paolo Bonzini
2012-11-28 21:37 ` [Qemu-devel] [PATCH] " Anthony Liguori
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2012-11-23 7:08 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel, Stefan Hajnoczi
On Thu, Nov 22, 2012 at 08:56:11PM +0100, Jan Kiszka wrote:
> The event notifier state is only reset by test_and_clear. But we created
> the windows event object with auto-reset, which subtly swallowed events.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> Grr, the last place I looked at after hours of debugging...
>
> event_notifier-win32.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
This should be in QEMU 1.3.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1.3] event notifier: Fix setup for win32
2012-11-23 7:08 ` Stefan Hajnoczi
@ 2012-11-28 11:40 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2012-11-28 11:40 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Jan Kiszka, Anthony Liguori, qemu-devel, Stefan Hajnoczi
Il 23/11/2012 08:08, Stefan Hajnoczi ha scritto:
> On Thu, Nov 22, 2012 at 08:56:11PM +0100, Jan Kiszka wrote:
>> The event notifier state is only reset by test_and_clear. But we created
>> the windows event object with auto-reset, which subtly swallowed events.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Grr, the last place I looked at after hours of debugging...
>>
>> event_notifier-win32.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> This should be in QEMU 1.3.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Anthony, the patch is at
http://article.gmane.org/gmane.comp.emulators.qemu/181608/raw
Please apply it for -rc2.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] event notifier: Fix setup for win32
2012-11-22 19:56 [Qemu-devel] [PATCH] event notifier: Fix setup for win32 Jan Kiszka
2012-11-23 7:08 ` Stefan Hajnoczi
@ 2012-11-28 21:37 ` Anthony Liguori
1 sibling, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2012-11-28 21:37 UTC (permalink / raw)
To: Jan Kiszka, qemu-devel; +Cc: Paolo Bonzini, Stefan Hajnoczi
Jan Kiszka <jan.kiszka@siemens.com> writes:
> The event notifier state is only reset by test_and_clear. But we created
> the windows event object with auto-reset, which subtly swallowed events.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
>
> Grr, the last place I looked at after hours of debugging...
>
> event_notifier-win32.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/event_notifier-win32.c b/event_notifier-win32.c
> index c723dad..4ed21c2 100644
> --- a/event_notifier-win32.c
> +++ b/event_notifier-win32.c
> @@ -16,7 +16,7 @@
>
> int event_notifier_init(EventNotifier *e, int active)
> {
> - e->event = CreateEvent(NULL, FALSE, FALSE, NULL);
> + e->event = CreateEvent(NULL, TRUE, FALSE, NULL);
> assert(e->event);
> return 0;
> }
> --
> 1.7.3.4
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-28 21:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-22 19:56 [Qemu-devel] [PATCH] event notifier: Fix setup for win32 Jan Kiszka
2012-11-23 7:08 ` Stefan Hajnoczi
2012-11-28 11:40 ` [Qemu-devel] [PATCH 1.3] " Paolo Bonzini
2012-11-28 21:37 ` [Qemu-devel] [PATCH] " Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).