Re: [Qemu-devel] [PATCH 11/41] ram: Export last_ram_offset()

[Anthony Liguori <anthony@codemonkey.ws>]

Juan Quintela <quintela@redhat.com> writes:

> Is the only way of knowing the RAM size.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  cpu-all.h | 2 ++
>  exec.c    | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/cpu-all.h b/cpu-all.h
> index 74d3681..5408782 100644
> --- a/cpu-all.h
> +++ b/cpu-all.h
> @@ -517,6 +517,8 @@ extern int mem_prealloc;
>  void dump_exec_info(FILE *f, fprintf_function cpu_fprintf);
>  #endif /* !CONFIG_USER_ONLY */
>
> +ram_addr_t last_ram_offset(void);
> +
>  int cpu_memory_rw_debug(CPUArchState *env, target_ulong addr,
>                          uint8_t *buf, int len, int is_write);

cpu-all.h is included by linux-user and ram_addr_t isn't available when
!CONFIG_USER_ONLY.

This breaks the build which also implies this series has only been
tested with a restricted target list.

Please make sure you don't submit pull requests without *at least* doing
a full build and 'make check'.

Regards,

Anthony Liguori

>
> diff --git a/exec.c b/exec.c
> index bb6aa4a..e613329 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2462,7 +2462,7 @@ static ram_addr_t find_ram_offset(ram_addr_t size)
>      return offset;
>  }
>
> -static ram_addr_t last_ram_offset(void)
> +ram_addr_t last_ram_offset(void)
>  {
>      RAMBlock *block;
>      ram_addr_t last = 0;
> -- 
> 1.7.11.4