From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39820)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TK8Qj-0004VK-Ft
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 09:59:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TK8Qd-0005Cr-F3
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 09:59:05 -0400
Received: from mail-oa0-f45.google.com ([209.85.219.45]:48233)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TK8Qd-0005CX-AI
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 09:58:59 -0400
Received: by mail-oa0-f45.google.com with SMTP id i18so1625455oag.4
	for <qemu-devel@nongnu.org>; Fri, 05 Oct 2012 06:58:58 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <506ED6B8.9020306@redhat.com>
References: <1349388419-21924-1-git-send-email-lmr@redhat.com>
	<1349388419-21924-2-git-send-email-lmr@redhat.com>
	<506E8C53.5050107@redhat.com> <87ehldccsj.fsf@codemonkey.ws>
	<506ED5DF.9030007@siemens.com> <506ED6B8.9020306@redhat.com>
Date: Fri, 05 Oct 2012 08:58:53 -0500
Message-ID: <87ehld6mw2.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit
	port (LGPL VGA BIOS port 0x501)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>, =?utf-8?Q?Herv=C3=A9?= Poussineau <hpoussin@reactos.org>, qemu-devel <qemu-devel@nongnu.org>

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il 05/10/2012 14:43, Jan Kiszka ha scritto:
>>>> >> This "| 1" might be the problem.  Anthony, are you relying on it in
>>>> >> qemu-test and/or can you work out the changes if we use just
>>>> >> "exit(val)"?
>>> > 
>>> > The reason for ' | 1' was to make sure that the guest couldn't trigger
>>> > an exit(0).
>>> > 
>>> > If there's a compelling reason to drop '| 1', I can adjust my tests
>>> > accordingly.
>> assert(val); (or hw_error)
>> exit(val);
>> 
>> I would suggest.
>
> I think what the kvm_unittests want is exactly to trigger an exit(0).
> Why did you rule it out?

Mainly to differientiate between an open coded exit(0)/exit(1) and
something triggered by the unit test.

The problem I tried to cope with was:

anthony@titi:~/git/qemu$ grep 'exit([01])' hw/*.c | wc -l
249

Regards,

Anthony Liguori

>
> Paolo