From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJTT4-0002tE-3x for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:14:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJTSy-0000CV-JG for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:14:46 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:47499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJTSy-0000Bx-0l for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:14:40 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 4 Oct 2012 04:12:26 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q93I4vjx30540004 for ; Thu, 4 Oct 2012 04:04:58 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q93IEUPv020427 for ; Thu, 4 Oct 2012 04:14:30 +1000 From: Anthony Liguori In-Reply-To: <506C74E0.8080409@web.de> References: <20121003105255.972669952@amt.cnet> <20121003105509.391284251@amt.cnet> <87fw5vhb5a.fsf@codemonkey.ws> <20121003150341.GA15164@amt.cnet> <506C5DED.7000705@web.de> <878vbn4gs9.fsf@codemonkey.ws> <506C74E0.8080409@web.de> Date: Wed, 03 Oct 2012 13:14:23 -0500 Message-ID: <87ehlftocg.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org, Gerd Hoffmann Jan Kiszka writes: > On 2012-10-03 19:16, Anthony Liguori wrote: >> Jan Kiszka writes: >> >>> On 2012-10-03 17:03, Marcelo Tosatti wrote: >>>> On Wed, Oct 03, 2012 at 09:40:17AM -0500, Anthony Liguori wrote: >>>>> Marcelo Tosatti writes: >>>>> >>>>>> Commit 3ad763fcba5bd0ec5a79d4a9b6baeef119dd4a3d from qemu-kvm.git. >>>>>> >>>>>> From: Jan Kiszka >>>>>> >>>>>> Upstream is moving towards this mechanism, so start using it in qemu-kvm >>>>>> already to configure the specific defaults: kvm enabled on, just like >>>>>> in-kernel irqchips. >>>>>> >>>>>> Signed-off-by: Marcelo Tosatti >>>>> >>>>> >>>>> Reviewed-by: Anthony Liguori >>>>> >>>>> Although it's a little odd to have From: Jan without a SoB... >>>> >>>> Agree, Jan can you ACK? >>> >>> I wasn't able to join the call yesterday: Is there a removal schedule >>> associated with those switches? Also, why pushing things upstream, even >>> when only for one release, that have been loudly deprecated for a while >>> in qemu-kvm? Some switches are lacking deprecated warnings on the >>> console, and -no-kvm is missing completely. I tend to focus on patch 1 & >>> 5, dropping the rest - based on relevance for production use. >> >> The distros need to keep these flags to do the switch. > > Why? Should be documented in commit log. > >> I see no point >> in deprecating them since they're trivially easy to maintain. > > Given the level of cr** we already have in the command line, they are > kind of noise, yes. But even then, these patches are not consistent as > pointed out above. > > Also, they should not be documented to avoid being spread. That's what > we did with other deprecated switches in QEMU. The patchset isn't checkpatch clean so I'll fix that, remove the docs, and send a new version tomorrow along with the machine changes. Regards, Anthony Liguori > > Jan