From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42710)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TJ00J-0004X0-Dq
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:47:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TJ00I-0008JB-Dq
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:47:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8245)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TJ00I-0008IT-67
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:47:06 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q92Al5sq005171
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 2 Oct 2012 06:47:05 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <505C5C1B.8000608@redhat.com> (Paolo Bonzini's message of "Fri,
	21 Sep 2012 14:22:51 +0200")
References: <1348217255-22441-1-git-send-email-quintela@redhat.com>
	<1348217255-22441-8-git-send-email-quintela@redhat.com>
	<505C5C1B.8000608@redhat.com>
Date: Tue, 02 Oct 2012 12:47:03 +0200
Message-ID: <87ehlh9mmw.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 07/41] migration: print expected downtime
	in info migrate
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 21/09/2012 10:47, Juan Quintela ha scritto:
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> Consider making the save_live functions return the expected downtime in
> an int64_t* argument.  The loop then can sum all the expected downtimes
> and store them in s->expected_downtime, removing the need for patch 6.

If you look at the migration thread patches, I change the functions to
return the "pending amount".  And the migration thread does the
bandwidth calculations.  It is just impossible to do the right
bandwidth calculation locally.

Later, Juan.