From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9MOx-0006AE-7s for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:40:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9MOu-0001f7-3A for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:40:42 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:46765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9MOu-0001et-01 for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:40:40 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 5 Sep 2012 16:40:39 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 27A0538C803B for ; Wed, 5 Sep 2012 16:40:36 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q85KeZ8V34013352 for ; Wed, 5 Sep 2012 16:40:35 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q85KeYIi032212 for ; Wed, 5 Sep 2012 17:40:34 -0300 From: Anthony Liguori In-Reply-To: <5047AA0D.8080008@web.de> References: <1346872724-9156-1-git-send-email-aliguori@us.ibm.com> <1346872724-9156-5-git-send-email-aliguori@us.ibm.com> <5047AA0D.8080008@web.de> Date: Wed, 05 Sep 2012 15:40:31 -0500 Message-ID: <87ehmg9pa8.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org Jan Kiszka writes: > On 2012-09-05 21:18, Anthony Liguori wrote: >> There is a small deviation from SDL's behavior here. Instead of Ctrl+Alt >> triggering grab, we now use Ctrl-Alt-g to trigger grab. >> >> GTK will not accept Ctrl+Alt as an accelerator since it just consists of >> modifiers. Having grab as a proper accelerator is important as it allows a user >> to override the accelerator for accessibility purposes. >> >> We also are not automatically grabbing on left-click. Besides the inability to >> tie mouse clicks to an accelerator, I think this behavior is hard to discover >> and since it only happens depending on the guest state, it can lead to confusing >> behavior. >> >> This can be changed in the future if there's a strong resistence to dropping >> left-click-to-grab, but I think we're better off dropping it. >> >> Signed-off-by: Anthony Liguori >> --- >> v1 -> v2 >> - add a menu option for grab on hover (Jan) > > Thanks. Are options like this persistent across VM starts? No. I don't want to include that in this series as it opens up a whole debate about GConf vs. configuration files... Regards, Anthony Liguori > > Jan