From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1RAfxm-0000bX-HR
	for qemu-devel@nongnu.org; Mon, 03 Oct 2011 06:41:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1RAfxl-0005YQ-IY
	for qemu-devel@nongnu.org; Mon, 03 Oct 2011 06:41:34 -0400
Received: from e34.co.us.ibm.com ([32.97.110.152]:53299)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1RAfxl-0005YK-Ba
	for qemu-devel@nongnu.org; Mon, 03 Oct 2011 06:41:33 -0400
Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com
	[9.17.195.226])
	by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p93AfLSA002787
	for <qemu-devel@nongnu.org>; Mon, 3 Oct 2011 04:41:21 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p93Af59t199106
	for <qemu-devel@nongnu.org>; Mon, 3 Oct 2011 04:41:20 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p93Af54v009875
	for <qemu-devel@nongnu.org>; Mon, 3 Oct 2011 04:41:05 -0600
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <20111003073752.GA31578@stefanha-thinkpad.localdomain>
References: <20110929232824.7CBA73FC28@buildbot.b1-systems.de>
	<CAJSP0QU_+oJ6Wv55XSOxqJWc0fw2xhAo46UuUiB2sFkiHhpyng@mail.gmail.com>
	<87pqih2im0.fsf@skywalker.in.ibm.com>
	<87mxdl2h0c.fsf@skywalker.in.ibm.com>
	<20111003073752.GA31578@stefanha-thinkpad.localdomain>
Date: Mon, 03 Oct 2011 16:10:50 +0530
Message-ID: <87ehyu2w99.fsf@skywalker.in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_rhel5
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: agraf@suse.de, gollub@b1-systems.de, qemu-devel@nongnu.org, lcapitulino@redhat.com

On Mon, 3 Oct 2011 08:37:52 +0100, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Sat, Oct 01, 2011 at 03:03:23PM +0530, Aneesh Kumar K.V wrote:
> > +#ifndef CONFIG_UTIMENSAT
> > +    /*
> > +     * We support handle fs driver only if all related
> > +     * syscalls are provided by host.
> > +     */
> 
> Perhaps a ./configure check should be added to see whether the handle
> syscalls are supported instead of using CONFIG_UTIMENSAT.
> 

We already do check for handle syscall. Since glibc doesn't have the
this syscall yet, I added the check in virtio-9p-handle.c as below

#ifdef __NR_name_to_handle_at
static inline int name_to_handle(int dirfd, const char *name,
                                 struct file_handle *fh, int *mnt_id, int flags)
{
    return syscall(__NR_name_to_handle_at, dirfd, name, fh, mnt_id, flags);
}
#else
static inline int name_to_handle(int dirfd, const char *name,
                                 struct file_handle *fh, int *mnt_id, int flags)
{
    errno = ENOSYS;
    return -1;
}


-aneesh