From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LUkRE-0005je-AA
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 11:17:20 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LUkRC-0005ih-G2
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 11:17:19 -0500
Received: from [199.232.76.173] (port=35436 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LUkRC-0005ic-8Y
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 11:17:18 -0500
Received: from mx2.redhat.com ([66.187.237.31]:55711)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1LUkRB-0006gc-RH
	for qemu-devel@nongnu.org; Wed, 04 Feb 2009 11:17:18 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n14GHHTK017883
	for <qemu-devel@nongnu.org>; Wed, 4 Feb 2009 11:17:17 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n14GHGZH016081
	for <qemu-devel@nongnu.org>; Wed, 4 Feb 2009 11:17:17 -0500
Received: from pike.pond.sub.org (vpn-10-108.str.redhat.com [10.32.10.108])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n14GHFg2003681
	for <qemu-devel@nongnu.org>; Wed, 4 Feb 2009 11:17:16 -0500
Subject: Re: [Qemu-devel] [patch 18/18] qemu: PCI device,
	disk and host network hot-add / hot-remove
References: <20090204133303.113145633@localhost.localdomain>
	<20090204133924.976199377@localhost.localdomain>
From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 04 Feb 2009 17:17:13 +0100
In-Reply-To: <20090204133924.976199377@localhost.localdomain> (Marcelo
	Tosatti's message of "Wed\, 04 Feb 2009 11\:33\:21 -0200")
Message-ID: <87eiyegos6.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>

Marcelo Tosatti <mtosatti@redhat.com> writes:

> Add monitor command to hot-add PCI devices (nic and storage).
>     
> Syntax is:
>     
> pci_add pcibus nic|storage params

I'd prefer a more future-proof syntax here.  Eventually, we'll want to
be able to specify the full PCI device address, consisting of domain,
bus and dev (func makes no sense here).  The common syntax for that is
"<domain>:<bus>:<dev>", with numbers in hexadecimal.  I figure we'll
want to make parts optional for convenience, and have some syntax to
let QEMU pick the <dev>.