From: Richard Henderson <richard.henderson@linaro.org>
To: Zhuojia Shen <chaosdefinition@hotmail.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [PATCH] target/arm: trap DCC access in user mode emulation
Date: Fri, 2 Jun 2023 21:52:03 -0700 [thread overview]
Message-ID: <87f06ed0-3ad2-6b14-6819-03a35e179682@linaro.org> (raw)
In-Reply-To: <DS7PR12MB630905198DD8E69F6817544CAC4EA@DS7PR12MB6309.namprd12.prod.outlook.com>
On 6/2/23 14:43, Zhuojia Shen wrote:
> Accessing EL0-accessible Debug Communication Channel (DCC) registers in
> user mode emulation is currently enabled. However, it does not match
> Linux behavior as Linux sets MDSCR_EL1.TDCC on startup to disable EL0
> access to DCC (see __cpu_setup() in arch/arm64/mm/proc.S).
>
> This patch fixes access_tdcc() to check MDSCR_EL1.TDCC for EL0 and sets
> MDSCR_EL1.TDCC for user mode emulation to match Linux.
>
> Signed-off-by: Zhuojia Shen <chaosdefinition@hotmail.com>
It would be nice to define the fields of MDSCR properly but either way,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-06-03 4:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 21:43 [PATCH] target/arm: trap DCC access in user mode emulation Zhuojia Shen
2023-06-03 4:52 ` Richard Henderson [this message]
2023-06-05 16:02 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87f06ed0-3ad2-6b14-6819-03a35e179682@linaro.org \
--to=richard.henderson@linaro.org \
--cc=chaosdefinition@hotmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).