Re: [PATCH v5 45/62] include: add QEMU_REPEAT helper macro

[Markus Armbruster <armbru@redhat.com>]

Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Introduce a macro used in following commit, and convert a few existing
> candidates. Inspired by a similar macro in Linux kernel/trace/bpf_trace.c
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

[...]

> diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c
> index 7e6819f670b5..84c3ff05cfb8 100644
> --- a/hw/remote/vfio-user-obj.c
> +++ b/hw/remote/vfio-user-obj.c
> @@ -496,22 +496,11 @@ static size_t vfu_object_bar_rw(PCIDevice *pci_dev, int pci_bar,
>                                   buf, count, is_write);                        \
>      }                                                                          \
>  
> -VFU_OBJECT_BAR_HANDLER(0)
> -VFU_OBJECT_BAR_HANDLER(1)
> -VFU_OBJECT_BAR_HANDLER(2)
> -VFU_OBJECT_BAR_HANDLER(3)
> -VFU_OBJECT_BAR_HANDLER(4)
> -VFU_OBJECT_BAR_HANDLER(5)
> -VFU_OBJECT_BAR_HANDLER(6)
> +QEMU_REPEAT(PCI_NUM_REGIONS, VFU_OBJECT_BAR_HANDLER)
>  
> +#define VFU_OBJECT_BAR_HANDLER_PTR(BAR_NO) vfu_object_bar##BAR_NO##_handler,

scripts/checkpatch.pl

    ERROR: Macros with complex values should be enclosed in parenthesis

False positive, I guess.  Can't see offhand how to avoid it.

>  static vfu_region_access_cb_t *vfu_object_bar_handlers[PCI_NUM_REGIONS] = {
> -    &vfu_object_bar0_handler,
> -    &vfu_object_bar1_handler,
> -    &vfu_object_bar2_handler,
> -    &vfu_object_bar3_handler,
> -    &vfu_object_bar4_handler,
> -    &vfu_object_bar5_handler,
> -    &vfu_object_bar6_handler,
> +    QEMU_REPEAT(PCI_NUM_REGIONS, VFU_OBJECT_BAR_HANDLER_PTR)
>  };
>  
>  /**

[...]