From: "Alex Bennée" <alex.bennee@linaro.org>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Huang Rui" <ray.huang@amd.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Antonio Caggiano" <quic_acaggian@quicinc.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Robert Beckett" <bob.beckett@collabora.com>,
"Gert Wollny" <gert.wollny@collabora.com>,
qemu-devel@nongnu.org,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
ernunes@redhat.com, "Alyssa Ross" <hi@alyssa.is>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Stefano Stabellini" <stefano.stabellini@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Xenia Ragiadakou" <xenia.ragiadakou@amd.com>,
"Pierre-Eric Pelloux-Prayer" <pierre-eric.pelloux-prayer@amd.com>,
"Honglei Huang" <honglei1.huang@amd.com>,
"Julia Zhang" <julia.zhang@amd.com>,
"Chen Jiqian" <Jiqian.Chen@amd.com>,
"Yiwei Zhang" <zzyiwei@chromium.org>
Subject: Re: [PATCH v14 12/14] virtio-gpu: Handle resource blob commands
Date: Wed, 19 Jun 2024 16:27:06 +0100 [thread overview]
Message-ID: <87frt9c5rp.fsf@draig.linaro.org> (raw)
In-Reply-To: <20240616010357.2874662-13-dmitry.osipenko@collabora.com> (Dmitry Osipenko's message of "Sun, 16 Jun 2024 04:03:55 +0300")
Dmitry Osipenko <dmitry.osipenko@collabora.com> writes:
> From: Antonio Caggiano <antonio.caggiano@collabora.com>
>
> Support BLOB resources creation, mapping and unmapping by calling the
> new stable virglrenderer 0.10 interface. Only enabled when available and
> via the blob config. E.g. -device virtio-vga-gl,blob=true
>
<snip>
>
> #if VIRGL_VERSION_MAJOR >= 1
> +static void virgl_cmd_resource_create_blob(VirtIOGPU *g,
> + struct virtio_gpu_ctrl_command *cmd)
> +{
> + struct virgl_renderer_resource_create_blob_args virgl_args = { 0 };
> + g_autofree struct virtio_gpu_virgl_resource *res;
Newer compilers rightly complain that g_free may be called on an
uninitialised value (if we early return). Setting to NULL should be
enough here.
<snip>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2024-06-19 15:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 1:03 [PATCH v14 00/14] Support blob memory and venus on qemu Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 01/14] virtio-gpu: Use trace events for tracking number of in-flight fences Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 02/14] virtio-gpu: Move fence_poll timer to VirtIOGPUGL Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 03/14] virtio-gpu: Move print_stats " Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 04/14] virtio-gpu: Handle virtio_gpu_virgl_init() failure Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 05/14] virtio-gpu: Unrealize GL device Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 06/14] virtio-gpu: Use pkgconfig version to decide which virgl features are available Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 07/14] virtio-gpu: Support context-init feature with virglrenderer Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 08/14] virtio-gpu: Don't require udmabuf when blobs and virgl are enabled Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 09/14] virtio-gpu: Add virgl resource management Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 10/14] virtio-gpu: Support blob scanout using dmabuf fd Dmitry Osipenko
2024-06-16 9:20 ` Akihiko Odaki
2024-06-16 1:03 ` [PATCH v14 11/14] virtio-gpu: Support suspension of commands processing Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 12/14] virtio-gpu: Handle resource blob commands Dmitry Osipenko
2024-06-16 9:23 ` Akihiko Odaki
2024-06-19 16:00 ` Dmitry Osipenko
2024-06-19 15:27 ` Alex Bennée [this message]
2024-06-19 15:59 ` Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 13/14] virtio-gpu: Register capsets dynamically Dmitry Osipenko
2024-06-16 1:03 ` [PATCH v14 14/14] virtio-gpu: Support Venus context Dmitry Osipenko
2024-06-19 17:37 ` [PATCH v14 00/14] Support blob memory and venus on qemu Alex Bennée
2024-06-20 17:34 ` Dmitry Osipenko
2024-06-21 8:59 ` Alex Bennée
2024-06-21 22:25 ` Dmitry Osipenko
2024-06-23 16:44 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frt9c5rp.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=Jiqian.Chen@amd.com \
--cc=akihiko.odaki@daynix.com \
--cc=alexander.deucher@amd.com \
--cc=bob.beckett@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dgilbert@redhat.com \
--cc=dmitry.osipenko@collabora.com \
--cc=ernunes@redhat.com \
--cc=gert.wollny@collabora.com \
--cc=gurchetansingh@chromium.org \
--cc=hi@alyssa.is \
--cc=honglei1.huang@amd.com \
--cc=julia.zhang@amd.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=quic_acaggian@quicinc.com \
--cc=ray.huang@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=xenia.ragiadakou@amd.com \
--cc=zzyiwei@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).