qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [RFC PATCH] tests/avocado: re-factor igb test to avoid timeouts
Date: Wed, 22 Mar 2023 14:56:04 +0000	[thread overview]
Message-ID: <87fs9w6dav.fsf@linaro.org> (raw)
In-Reply-To: <3bd3dd15-3b81-f198-f701-e679d6a99234@daynix.com>


Akihiko Odaki <akihiko.odaki@daynix.com> writes:

<snip>
>>    - The various "full-fat" distros we run avocado tests for seem to be
>>      very bloated (esp compared to my local Debian setup which boots very
>>      quickly) >    - It's hard to argue with the time saving and stability improvements,
>>      especially as we are limited on CI time these days
>> 
>
> You don't have to perform the normal userspace initialization the
> distribution comes with for this workload. We can just add something
> like the following to the kernel command line:
> init=/bin/sh -- -c "rpm -i /path/to/ethtool.rpm && ethtool -t eth1 offline"
>
> This is very similar to what Docker containers do. In Docker, you do
> not run daemons like systemd but directly run the application or use
> very small init.
>
> The reason why I didn't write the tests in this way is because the
> current testing infrastructure does not have a means to provide a file
> to the guest. I think adding such functionality is much simpler than
> introducing Buildroot.

I don't really have time to add a new feature to avocado to get this PR
dealt with (the original reason I was looking at this test was trying to
figure out why it was stalling on the centos-8-stream custom runner).

I've sent out a v2 which incorporates your other feedback and speeds the
test up some more with the direct call from init. I'll include this
version in the re-roll of the testing PR. We can always look at
reverting it to using fedora after v8.0 is out. In the meantime its just
one more random test binary I'm serving amongst the many I already
support.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


      reply	other threads:[~2023-03-22 15:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 18:17 [RFC PATCH] tests/avocado: re-factor igb test to avoid timeouts Alex Bennée
2023-03-21 21:49 ` Philippe Mathieu-Daudé
2023-03-22  5:32 ` Akihiko Odaki
2023-03-22 10:04   ` Alex Bennée
2023-03-22 11:02     ` Akihiko Odaki
2023-03-22 11:22       ` Alex Bennée
2023-03-22 11:40         ` Akihiko Odaki
2023-03-22 14:56           ` Alex Bennée [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs9w6dav.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=akihiko.odaki@daynix.com \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).