* [PATCH] Fix virtio-net-pci* "vectors" compat
@ 2021-11-03 8:52 Jean-Louis Dupond
2021-11-03 9:36 ` Cornelia Huck
0 siblings, 1 reply; 3+ messages in thread
From: Jean-Louis Dupond @ 2021-11-03 8:52 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost, mst, Jason Wang, Jean-Louis Dupond
From: Eduardo Habkost <ehabkost@redhat.com>
hw_compat_5_2 has an issue: it affects only "virtio-net-pci"
but not "virtio-net-pci-transitional" and
"virtio-net-pci-non-transitional". The solution is to use the
"virtio-net-pci-base" type in compat_props.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Jean-Louis Dupond <jean-louis@dupond.be>
---
hw/core/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index e24e3e27db..b17a15508c 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -56,7 +56,7 @@ GlobalProperty hw_compat_5_2[] = {
{ "ICH9-LPC", "smm-compat", "on"},
{ "PIIX4_PM", "smm-compat", "on"},
{ "virtio-blk-device", "report-discard-granularity", "off" },
- { "virtio-net-pci", "vectors", "3"},
+ { "virtio-net-pci-base", "vectors", "3"},
};
const size_t hw_compat_5_2_len = G_N_ELEMENTS(hw_compat_5_2);
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix virtio-net-pci* "vectors" compat
2021-11-03 8:52 [PATCH] Fix virtio-net-pci* "vectors" compat Jean-Louis Dupond
@ 2021-11-03 9:36 ` Cornelia Huck
0 siblings, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2021-11-03 9:36 UTC (permalink / raw)
To: Jean-Louis Dupond, qemu-devel
Cc: Jason Wang, Jean-Louis Dupond, ehabkost, mst
On Wed, Nov 03 2021, Jean-Louis Dupond <jean-louis@dupond.be> wrote:
> From: Eduardo Habkost <ehabkost@redhat.com>
>
> hw_compat_5_2 has an issue: it affects only "virtio-net-pci"
> but not "virtio-net-pci-transitional" and
> "virtio-net-pci-non-transitional". The solution is to use the
> "virtio-net-pci-base" type in compat_props.
>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
> Acked-by: Jean-Louis Dupond <jean-louis@dupond.be>
<process>This needs to have your s-o-b at the bottom, as you passed
Eduardo's patch on.</process>
> ---
> hw/core/machine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Fix virtio-net-pci* "vectors" compat
@ 2021-11-03 10:45 Jean-Louis Dupond
0 siblings, 0 replies; 3+ messages in thread
From: Jean-Louis Dupond @ 2021-11-03 10:45 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost, mst, Jean-Louis Dupond, Jason Wang, Cornelia Huck
From: Eduardo Habkost <ehabkost@redhat.com>
hw_compat_5_2 has an issue: it affects only "virtio-net-pci"
but not "virtio-net-pci-transitional" and
"virtio-net-pci-non-transitional". The solution is to use the
"virtio-net-pci-base" type in compat_props.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Jean-Louis Dupond <jean-louis@dupond.be>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
hw/core/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index e24e3e27db..b17a15508c 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -56,7 +56,7 @@ GlobalProperty hw_compat_5_2[] = {
{ "ICH9-LPC", "smm-compat", "on"},
{ "PIIX4_PM", "smm-compat", "on"},
{ "virtio-blk-device", "report-discard-granularity", "off" },
- { "virtio-net-pci", "vectors", "3"},
+ { "virtio-net-pci-base", "vectors", "3"},
};
const size_t hw_compat_5_2_len = G_N_ELEMENTS(hw_compat_5_2);
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-03 10:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-03 8:52 [PATCH] Fix virtio-net-pci* "vectors" compat Jean-Louis Dupond
2021-11-03 9:36 ` Cornelia Huck
-- strict thread matches above, loose matches on Subject: below --
2021-11-03 10:45 Jean-Louis Dupond
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).