From: "Alex Bennée" <alex.bennee@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: sgarzare@redhat.com, jag.raman@oracle.com, qemu-devel@nongnu.org,
stefanha@redhat.com, mst@redhat.com
Subject: Re: [PATCH 1/3] docs: vhost-user: clean up request/reply description
Date: Mon, 01 Mar 2021 11:33:02 +0000 [thread overview]
Message-ID: <87ft1fjeet.fsf@linaro.org> (raw)
In-Reply-To: <20210226143413.188046-2-pbonzini@redhat.com>
Paolo Bonzini <pbonzini@redhat.com> writes:
> It is not necessary to mention which side is sending/receiving
> each payload; it is more interesting to say which is the request
> and which is the reply. This also matches what vhost-user-gpu.rst
> already does.
>
> While at it, ensure that all messages list both the request and
> the reply payload.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
<snip>
>
> When the ``VHOST_USER_PROTOCOL_F_STATUS`` protocol feature has been
> successfully negotiated, this message is submitted by the master to
> @@ -1351,11 +1375,14 @@ Master message types
> Slave message types
> -------------------
>
> +For this type of message, the request is sent by the slave and the reply
> +is sent by the master.
> +
It may be worth pointing out this language will be changed in a follow
up patch in the commit.
Otherwise:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2021-03-01 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 14:34 [PATCH 0/3] docs: replace master/slave with more accurate wording Paolo Bonzini
2021-02-26 14:34 ` [PATCH 1/3] docs: vhost-user: clean up request/reply description Paolo Bonzini
2021-03-01 8:12 ` Philippe Mathieu-Daudé
2021-03-01 10:16 ` Stefan Hajnoczi
2021-03-01 10:32 ` Stefano Garzarella
2021-03-01 10:49 ` Paolo Bonzini
2021-03-01 11:33 ` Alex Bennée [this message]
2021-02-26 14:34 ` [PATCH 2/3] docs: vhost-user: rewrite section on ring state machine Paolo Bonzini
2021-03-01 10:16 ` Stefan Hajnoczi
2021-02-26 14:34 ` [PATCH 3/3] docs: vhost-user: replace master/slave with front-end/back-end Paolo Bonzini
2021-03-01 10:23 ` Stefan Hajnoczi
2021-03-01 10:48 ` Paolo Bonzini
2021-02-26 14:48 ` [PATCH 0/3] docs: replace master/slave with more accurate wording Jag Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft1fjeet.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=jag.raman@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).