From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB53FC433E0 for ; Mon, 1 Mar 2021 11:35:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 780BE64E22 for ; Mon, 1 Mar 2021 11:35:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 780BE64E22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGgqA-0004Aq-6z for qemu-devel@archiver.kernel.org; Mon, 01 Mar 2021 06:35:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGgp2-0003Hk-1w for qemu-devel@nongnu.org; Mon, 01 Mar 2021 06:34:45 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:39215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGgow-0003jn-TG for qemu-devel@nongnu.org; Mon, 01 Mar 2021 06:34:41 -0500 Received: by mail-wm1-x330.google.com with SMTP id u125so14096749wmg.4 for ; Mon, 01 Mar 2021 03:34:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=2DkY5FKQDLjz7HV/P2Zb0ewg0ObbzrHqwB7pqZsNJqA=; b=Sde+K6VkFL9M/pkeEm/8ZOWL5sid38/hgqO70sA7aTKTgSIF5+CUFhpiGufi6EGp9V I6Toc+q3mf1lffKEUYxjo2JStNVks82ShrWgAWNXDvKBkyI/OGACxnLd7zjAXIizLdir afl1GS6uWcvzUwVSoRFqyHTBzzDo+7VspJKEjIhL7mi71jdTdAKDSjZOWi1ZLjsac7qS ONdyTCQ9Gg/R0Sm69jZsGXJns0IN+6jqTpNFGubMYVxnMNikgHB5ZopBcYcsGLPHdd4p kKN8AF7RuYqGBb0qRRaFO/jHRENOLjhA2tE89Eqc1sKpE2JVPFkEKgNNrGGRW/dwsukn 2SQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=2DkY5FKQDLjz7HV/P2Zb0ewg0ObbzrHqwB7pqZsNJqA=; b=i7OwUoVa/wR8FOBBq3EtbU0HXo4FmbooMifvZb4m+qVlzNsCw0HN+JHIjjLRAbyar+ s0XlbY3myEAGlw7+H7bXXYtUEvzruFE4SVNanaH/LRBsH3GIlV4k4z+4+Dhg3VrZgyvZ IOJXzuc7SaPjMQv1pncK2GisoNdXZ9HnTcsYgNUf0DSwL5Gv0EWktewSw7hvtaytA04x FaIiIRJFUIj7y/qPaly7ZIoXoAi69yX2nTWlANHkjz0NJZMkUnHsLVXqgzPkpukAAml1 ufYnWO6CwBkSl/fYqEyh/jPr/RAC9/vrKAsLyXiIGgm/wk3s0QXF0H1euqzjGUm8pqB8 EWHg== X-Gm-Message-State: AOAM5308Isvo0j940ISwxzmfh7gxXY/0eFrqthQzFb+oiooocGq6OpNv YEYf1kErbirDtSPlbse5zYynFUwgEbwqcg== X-Google-Smtp-Source: ABdhPJyFeet19ascsfuTDgh4zPSeU+IZVGAYb/kZR5ELPgoUlsDDWW7Rt24at3l0jL0uJvNGgDZzEA== X-Received: by 2002:a7b:c842:: with SMTP id c2mr15511878wml.100.1614598475842; Mon, 01 Mar 2021 03:34:35 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 4sm23515020wma.0.2021.03.01.03.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Mar 2021 03:34:34 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 218EF1FF7E; Mon, 1 Mar 2021 11:34:34 +0000 (GMT) References: <20210226143413.188046-1-pbonzini@redhat.com> <20210226143413.188046-2-pbonzini@redhat.com> User-agent: mu4e 1.5.8; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Paolo Bonzini Subject: Re: [PATCH 1/3] docs: vhost-user: clean up request/reply description Date: Mon, 01 Mar 2021 11:33:02 +0000 In-reply-to: <20210226143413.188046-2-pbonzini@redhat.com> Message-ID: <87ft1fjeet.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sgarzare@redhat.com, jag.raman@oracle.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Paolo Bonzini writes: > It is not necessary to mention which side is sending/receiving > each payload; it is more interesting to say which is the request > and which is the reply. This also matches what vhost-user-gpu.rst > already does. > > While at it, ensure that all messages list both the request and > the reply payload. > > Signed-off-by: Paolo Bonzini >=20=20 > When the ``VHOST_USER_PROTOCOL_F_STATUS`` protocol feature has been > successfully negotiated, this message is submitted by the master to > @@ -1351,11 +1375,14 @@ Master message types > Slave message types > ------------------- >=20=20 > +For this type of message, the request is sent by the slave and the reply > +is sent by the master. > + It may be worth pointing out this language will be changed in a follow up patch in the commit. Otherwise: Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e