From: "Alex Bennée" <alex.bennee@linaro.org>
To: AlexChen <alex.chen@huawei.com>
Cc: zhang.zhanghailiang@huawei.com, qemu-trivial@nongnu.org,
mjt@tls.msk.ru, Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org, zhengchuan@huawei.com
Subject: Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket()
Date: Thu, 05 Nov 2020 10:37:04 +0000 [thread overview]
Message-ID: <87ft5oay3z.fsf@linaro.org> (raw)
In-Reply-To: <5FA3A17C.30108@huawei.com>
AlexChen <alex.chen@huawei.com> writes:
> Kindly ping.
Ahh sorry I missed these. Was there a cover letter for the series?
>
> On 2020/10/28 21:45, AlexChen wrote:
>> Close the fd when connect() fails.
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: AlexChen <alex.chen@huawei.com>
>> ---
>> contrib/plugins/lockstep.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
>> index a696673dff..319bd44b83 100644
>> --- a/contrib/plugins/lockstep.c
>> +++ b/contrib/plugins/lockstep.c
>> @@ -292,6 +292,7 @@ static bool connect_socket(const char *path)
>>
>> if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) {
>> perror("failed to connect");
>> + close(fd);
>> return false;
>> }
>>
--
Alex Bennée
next prev parent reply other threads:[~2020-11-05 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 13:45 [PATCH 1/2] plugins: Fix resource leak in connect_socket() AlexChen
2020-11-05 6:53 ` AlexChen
2020-11-05 10:37 ` Alex Bennée [this message]
2020-11-06 1:40 ` AlexChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft5oay3z.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=alex.chen@huawei.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).