From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi, richard.henderson@linaro.org,
laurent@vivier.eu, "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v1 7/7] translate-all: include guest address in out_asm output
Date: Thu, 07 May 2020 10:47:29 +0100 [thread overview]
Message-ID: <87ftcc5b66.fsf@linaro.org> (raw)
In-Reply-To: <20200501145713.19822-8-alex.bennee@linaro.org>
Alex Bennée <alex.bennee@linaro.org> writes:
<snip>
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index a2268d9db0..f5e4529df2 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -4211,6 +4211,7 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb)
> }
> tcg_debug_assert(num_insns >= 0);
> s->gen_insn_end_off[num_insns] = tcg_current_code_size(s);
> + s->gen_insn_end_off[num_insns + 1] = 0;
OK this was lazy of me and of course vulnerable to an overflow. Did you
know the sha1 test is quite capable of exceeding this?
--
Alex Bennée
next prev parent reply other threads:[~2020-05-07 9:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 14:57 [PATCH v1 0/7] various tcg and linux-user updates Alex Bennée
2020-05-01 14:57 ` [PATCH v1 1/7] linux-user: completely re-write init_guest_space Alex Bennée
2020-05-01 14:57 ` [PATCH v1 2/7] exec/cpu-all: Use bool for have_guest_base Alex Bennée
2020-05-01 14:57 ` [PATCH v1 3/7] accel/tcg: Relax va restrictions on 64-bit guests Alex Bennée
2020-05-01 14:57 ` [PATCH v1 4/7] accel/tcg: don't disable exec_tb trace events Alex Bennée
2020-05-11 12:16 ` Philippe Mathieu-Daudé
2020-05-01 14:57 ` [PATCH v1 5/7] disas: include an optional note for the start of disassembly Alex Bennée
2020-05-01 15:08 ` Philippe Mathieu-Daudé
2020-05-01 14:57 ` [PATCH v1 6/7] disas: add optional note support to cap_disas Alex Bennée
2020-05-11 12:18 ` Philippe Mathieu-Daudé
2020-05-01 14:57 ` [PATCH v1 7/7] translate-all: include guest address in out_asm output Alex Bennée
2020-05-07 9:47 ` Alex Bennée [this message]
2020-05-11 11:12 ` [PATCH v1 0/7] various tcg and linux-user updates Alex Bennée
2020-05-11 18:05 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftcc5b66.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).