From: Markus Armbruster <armbru@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/4] net: fix assertion failure when ipv6-prefixlen is not a number
Date: Thu, 16 May 2019 10:26:15 +0200 [thread overview]
Message-ID: <87ftpevm8o.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190509130345.227526-2-sgarzare@redhat.com> (Stefano Garzarella's message of "Thu, 9 May 2019 15:03:42 +0200")
Stefano Garzarella <sgarzare@redhat.com> writes:
> If 'ipv6-prefixlen' is not a number, the current behaviour
> produces an assertion failure:
> $ qemu-system-x86_64 -net user,ipv6-net=feca::0/a
> qemu-system-x86_64: qemu/util/qemu-option.c:1175: qemu_opts_foreach:
> Assertion `!errp || !*errp' failed.
> Aborted (core dumped)
>
> This patch fixes it, jumping to the end of the function when
> 'ipv6-prefixlen' is not a number, and printing the more friendly
> message:
> $ qemu-system-x86_64 -net user,ipv6-net=feca::0/a
> qemu-system-x86_64: Parameter 'ipv6-prefixlen' expects a number
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2019-05-16 8:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 13:03 [Qemu-devel] [PATCH v2 0/4] Clean ups in net/net.c Stefano Garzarella
2019-05-09 13:03 ` [Qemu-devel] [PATCH v2 1/4] net: fix assertion failure when ipv6-prefixlen is not a number Stefano Garzarella
2019-05-16 8:26 ` Markus Armbruster [this message]
2019-05-09 13:03 ` [Qemu-devel] [PATCH v2 2/4] net: avoid using variable length array in net_client_init() Stefano Garzarella
2019-05-16 8:44 ` Markus Armbruster
2019-05-16 11:41 ` Stefano Garzarella
2019-05-09 13:03 ` [Qemu-devel] [PATCH v2 3/4] net: use g_strsplit() for parsing host address and port Stefano Garzarella
2019-05-16 8:46 ` Markus Armbruster
2019-05-09 13:03 ` [Qemu-devel] [PATCH v2 4/4] net: remove unused get_str_sep() function Stefano Garzarella
2019-05-16 8:47 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftpevm8o.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).