From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 02/19] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan
Date: Fri, 11 May 2018 08:47:03 +0100 [thread overview]
Message-ID: <87fu2yvdl4.fsf@linaro.org> (raw)
In-Reply-To: <20180511004345.26708-3-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> The new function assumes that the input is an SNaN and
> does not double-check.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> fpu/softfloat-specialize.h | 174 +++++++++++++++++++++++++------------
> include/fpu/softfloat.h | 5 ++
> 2 files changed, 123 insertions(+), 56 deletions(-)
>
> diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
> index 8bd553abd2..b59356f6a5 100644
> --- a/fpu/softfloat-specialize.h
> +++ b/fpu/softfloat-specialize.h
> @@ -271,22 +271,35 @@ int float16_is_signaling_nan(float16 a_, float_status *status)
> #endif
> }
>
> +/*----------------------------------------------------------------------------
> +| Returns a quiet NaN from a signalling NaN for the half-precision
> +| floating point value `a'.
> +*----------------------------------------------------------------------------*/
> +
> +float16 float16_silence_nan(float16 a, float_status *status)
> +{
> +#ifdef NO_SIGNALING_NANS
> + g_assert_not_reached();
> +#else
> + if (status->snan_bit_is_one) {
> + return float16_default_nan(status);
> + } else {
> + return a | (1 << 9);
> + }
> +#endif
> +}
> +
> /*----------------------------------------------------------------------------
> | Returns a quiet NaN if the half-precision floating point value `a' is a
> | signaling NaN; otherwise returns `a'.
> *----------------------------------------------------------------------------*/
> -float16 float16_maybe_silence_nan(float16 a_, float_status *status)
> +
> +float16 float16_maybe_silence_nan(float16 a, float_status *status)
> {
> - if (float16_is_signaling_nan(a_, status)) {
> - if (status->snan_bit_is_one) {
> - return float16_default_nan(status);
> - } else {
> - uint16_t a = float16_val(a_);
> - a |= (1 << 9);
> - return make_float16(a);
> - }
> + if (float16_is_signaling_nan(a, status)) {
> + float16_silence_nan(a, status);
> }
> - return a_;
> + return a;
> }
>
> /*----------------------------------------------------------------------------
> @@ -327,30 +340,40 @@ int float32_is_signaling_nan(float32 a_, float_status *status)
> #endif
> }
>
> +/*----------------------------------------------------------------------------
> +| Returns a quiet NaN from a signalling NaN for the single-precision
> +| floating point value `a'.
> +*----------------------------------------------------------------------------*/
> +
> +float32 float32_silence_nan(float32 a, float_status *status)
> +{
> +#ifdef NO_SIGNALING_NANS
> + g_assert_not_reached();
> +#else
> + if (status->snan_bit_is_one) {
> +# ifdef TARGET_HPPA
> + a &= ~0x00400000;
> + a |= 0x00200000;
> + return a;
> +# else
> + return float32_default_nan(status);
> +# endif
> + } else {
> + return a | (1 << 22);
> + }
> +#endif
> +}
> /*----------------------------------------------------------------------------
> | Returns a quiet NaN if the single-precision floating point value `a' is a
> | signaling NaN; otherwise returns `a'.
> *----------------------------------------------------------------------------*/
>
> -float32 float32_maybe_silence_nan(float32 a_, float_status *status)
> +float32 float32_maybe_silence_nan(float32 a, float_status *status)
> {
> - if (float32_is_signaling_nan(a_, status)) {
> - if (status->snan_bit_is_one) {
> -#ifdef TARGET_HPPA
> - uint32_t a = float32_val(a_);
> - a &= ~0x00400000;
> - a |= 0x00200000;
> - return make_float32(a);
> -#else
> - return float32_default_nan(status);
> -#endif
> - } else {
> - uint32_t a = float32_val(a_);
> - a |= (1 << 22);
> - return make_float32(a);
> - }
> + if (float32_is_signaling_nan(a, status)) {
> + float32_silence_nan(a, status);
> }
> - return a_;
> + return a;
> }
>
> /*----------------------------------------------------------------------------
> @@ -736,30 +759,41 @@ int float64_is_signaling_nan(float64 a_, float_status *status)
> #endif
> }
>
> +/*----------------------------------------------------------------------------
> +| Returns a quiet NaN from a signalling NaN for the double-precision
> +| floating point value `a'.
> +*----------------------------------------------------------------------------*/
> +
> +float64 float64_silence_nan(float64 a, float_status *status)
> +{
> +#ifdef NO_SIGNALING_NANS
> + g_assert_not_reached();
> +#else
> + if (status->snan_bit_is_one) {
> +# ifdef TARGET_HPPA
> + a &= ~0x0008000000000000ULL;
> + a |= 0x0004000000000000ULL;
> + return a;
> +# else
> + return float64_default_nan(status);
> +# endif
> + } else {
> + return a | LIT64(0x0008000000000000);
> + }
> +#endif
> +}
> +
> /*----------------------------------------------------------------------------
> | Returns a quiet NaN if the double-precision floating point value `a' is a
> | signaling NaN; otherwise returns `a'.
> *----------------------------------------------------------------------------*/
>
> -float64 float64_maybe_silence_nan(float64 a_, float_status *status)
> +float64 float64_maybe_silence_nan(float64 a, float_status *status)
> {
> - if (float64_is_signaling_nan(a_, status)) {
> - if (status->snan_bit_is_one) {
> -#ifdef TARGET_HPPA
> - uint64_t a = float64_val(a_);
> - a &= ~0x0008000000000000ULL;
> - a |= 0x0004000000000000ULL;
> - return make_float64(a);
> -#else
> - return float64_default_nan(status);
> -#endif
> - } else {
> - uint64_t a = float64_val(a_);
> - a |= LIT64(0x0008000000000000);
> - return make_float64(a);
> - }
> + if (float64_is_signaling_nan(a, status)) {
> + return float64_silence_nan(a, status);
> }
> - return a_;
> + return a;
> }
>
> /*----------------------------------------------------------------------------
> @@ -897,6 +931,25 @@ int floatx80_is_signaling_nan(floatx80 a, float_status *status)
> #endif
> }
>
> +/*----------------------------------------------------------------------------
> +| Returns a quiet NaN from a signalling NaN for the extended double-precision
> +| floating point value `a'.
> +*----------------------------------------------------------------------------*/
> +
> +floatx80 floatx80_silence_nan(floatx80 a, float_status *status)
> +{
> +#ifdef NO_SIGNALING_NANS
> + g_assert_not_reached();
> +#else
> + if (status->snan_bit_is_one) {
> + return floatx80_default_nan(status);
> + } else {
> + a.low |= LIT64(0xC000000000000000);
> + return a;
> + }
> +#endif
> +}
> +
> /*----------------------------------------------------------------------------
> | Returns a quiet NaN if the extended double-precision floating point value
> | `a' is a signaling NaN; otherwise returns `a'.
> @@ -905,12 +958,7 @@ int floatx80_is_signaling_nan(floatx80 a, float_status *status)
> floatx80 floatx80_maybe_silence_nan(floatx80 a, float_status *status)
> {
> if (floatx80_is_signaling_nan(a, status)) {
> - if (status->snan_bit_is_one) {
> - a = floatx80_default_nan(status);
> - } else {
> - a.low |= LIT64(0xC000000000000000);
> - return a;
> - }
> + return floatx80_silence_nan(a, status);
> }
> return a;
> }
> @@ -1044,6 +1092,25 @@ int float128_is_signaling_nan(float128 a, float_status *status)
> #endif
> }
>
> +/*----------------------------------------------------------------------------
> +| Returns a quiet NaN from a signalling NaN for the quadruple-precision
> +| floating point value `a'.
> +*----------------------------------------------------------------------------*/
> +
> +float128 float128_silence_nan(float128 a, float_status *status)
> +{
> +#ifdef NO_SIGNALING_NANS
> + g_assert_not_reached();
> +#else
> + if (status->snan_bit_is_one) {
> + return float128_default_nan(status);
> + } else {
> + a.high |= LIT64(0x0000800000000000);
> + return a;
> + }
> +#endif
> +}
> +
> /*----------------------------------------------------------------------------
> | Returns a quiet NaN if the quadruple-precision floating point value `a' is
> | a signaling NaN; otherwise returns `a'.
> @@ -1052,12 +1119,7 @@ int float128_is_signaling_nan(float128 a, float_status *status)
> float128 float128_maybe_silence_nan(float128 a, float_status *status)
> {
> if (float128_is_signaling_nan(a, status)) {
> - if (status->snan_bit_is_one) {
> - a = float128_default_nan(status);
> - } else {
> - a.high |= LIT64(0x0000800000000000);
> - return a;
> - }
> + return float128_silence_nan(a, status);
> }
> return a;
> }
> diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
> index 01ef1c6b81..a6860e858d 100644
> --- a/include/fpu/softfloat.h
> +++ b/include/fpu/softfloat.h
> @@ -257,6 +257,7 @@ int float16_compare_quiet(float16, float16, float_status *status);
>
> int float16_is_quiet_nan(float16, float_status *status);
> int float16_is_signaling_nan(float16, float_status *status);
> +float16 float16_silence_nan(float16, float_status *status);
> float16 float16_maybe_silence_nan(float16, float_status *status);
>
> static inline int float16_is_any_nan(float16 a)
> @@ -368,6 +369,7 @@ float32 float32_minnummag(float32, float32, float_status *status);
> float32 float32_maxnummag(float32, float32, float_status *status);
> int float32_is_quiet_nan(float32, float_status *status);
> int float32_is_signaling_nan(float32, float_status *status);
> +float32 float32_silence_nan(float32, float_status *status);
> float32 float32_maybe_silence_nan(float32, float_status *status);
> float32 float32_scalbn(float32, int, float_status *status);
>
> @@ -497,6 +499,7 @@ float64 float64_minnummag(float64, float64, float_status *status);
> float64 float64_maxnummag(float64, float64, float_status *status);
> int float64_is_quiet_nan(float64 a, float_status *status);
> int float64_is_signaling_nan(float64, float_status *status);
> +float64 float64_silence_nan(float64, float_status *status);
> float64 float64_maybe_silence_nan(float64, float_status *status);
> float64 float64_scalbn(float64, int, float_status *status);
>
> @@ -600,6 +603,7 @@ int floatx80_compare(floatx80, floatx80, float_status *status);
> int floatx80_compare_quiet(floatx80, floatx80, float_status *status);
> int floatx80_is_quiet_nan(floatx80, float_status *status);
> int floatx80_is_signaling_nan(floatx80, float_status *status);
> +floatx80 floatx80_silence_nan(floatx80, float_status *status);
> floatx80 floatx80_maybe_silence_nan(floatx80, float_status *status);
> floatx80 floatx80_scalbn(floatx80, int, float_status *status);
>
> @@ -811,6 +815,7 @@ int float128_compare(float128, float128, float_status *status);
> int float128_compare_quiet(float128, float128, float_status *status);
> int float128_is_quiet_nan(float128, float_status *status);
> int float128_is_signaling_nan(float128, float_status *status);
> +float128 float128_silence_nan(float128, float_status *status);
> float128 float128_maybe_silence_nan(float128, float_status *status);
> float128 float128_scalbn(float128, int, float_status *status);
--
Alex Bennée
next prev parent reply other threads:[~2018-05-11 7:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 0:43 [Qemu-devel] [PATCH 00/19] softfloat: Clean up NaN handling Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 01/19] fpu/softfloat: Merge NO_SIGNALING_NANS definitions Richard Henderson
2018-05-11 6:44 ` Alex Bennée
2018-05-11 0:43 ` [Qemu-devel] [PATCH 02/19] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan Richard Henderson
2018-05-11 7:47 ` Alex Bennée [this message]
2018-05-11 15:06 ` Alex Bennée
2018-05-11 15:16 ` Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 03/19] fpu/softfloat: Move softfloat-specialize.h below FloatParts definition Richard Henderson
2018-05-11 7:48 ` Alex Bennée
2018-05-11 0:43 ` [Qemu-devel] [PATCH 04/19] fpu/softfloat: Canonicalize NaN fraction Richard Henderson
2018-05-11 16:26 ` Alex Bennée
2018-05-11 16:46 ` Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 05/19] fpu/softfloat: Introduce parts_is_snan_frac Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 06/19] fpu/softfloat: Replace float_class_dnan with parts_default_nan Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 07/19] fpu/softfloat: Replace float_class_msnan with parts_silence_nan Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 08/19] target/arm: Use floatX_silence_nan when we have already checked for SNaN Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 09/19] target/arm: Remove floatX_maybe_silence_nan from conversions Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 10/19] target/hppa: " Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 11/19] target/m68k: Use floatX_silence_nan when we have already checked for SNaN Richard Henderson
2018-05-11 10:11 ` Laurent Vivier
2018-05-11 0:43 ` [Qemu-devel] [PATCH 12/19] target/mips: Remove floatX_maybe_silence_nan from conversions Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 13/19] target/riscv: " Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 14/19] target/s390x: " Richard Henderson
2018-05-11 6:47 ` David Hildenbrand
2018-05-11 0:43 ` [Qemu-devel] [PATCH 15/19] fpu/softfloat: Use float*_silence_nan in propagateFloat*NaN Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 16/19] fpu/softfloat: Remove floatX_maybe_silence_nan Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 17/19] fpu/softfloat: Introduce SNAN_BIT_IS_ONE Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 18/19] fpu/softfloat: Pass FloatClass to pickNaN Richard Henderson
2018-05-11 0:43 ` [Qemu-devel] [PATCH 19/19] fpu/softfloat: Pass FloatClass to pickNaNMulAdd Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu2yvdl4.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).