From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmg5Z-000430-B4 for qemu-devel@nongnu.org; Wed, 21 Sep 2016 07:53:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmg5W-0001sz-3N for qemu-devel@nongnu.org; Wed, 21 Sep 2016 07:53:21 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmg5U-0001s2-Qu for qemu-devel@nongnu.org; Wed, 21 Sep 2016 07:53:18 -0400 Received: by mail-wm0-f43.google.com with SMTP id l132so87081549wmf.1 for ; Wed, 21 Sep 2016 04:53:16 -0700 (PDT) References: <20160814225339.482797.79805@ex-std-node742.prod.rhcloud.com> <1471219193.12231.78.camel@kernel.crashing.org> <87intpblrm.fsf@linaro.org> <1474454419.2857.122.camel@kernel.crashing.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1474454419.2857.122.camel@kernel.crashing.org> Date: Wed, 21 Sep 2016 12:52:14 +0100 Message-ID: <87fuotbhch.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, famz@redhat.com Benjamin Herrenschmidt writes: > On Wed, 2016-09-21 at 11:16 +0100, Alex Bennée wrote: >> >> > > >> > > total: 428 errors, 73 warnings, 1950 lines checked >> > > >> > > Your patch has style problems, please review.If any of these >> > > errors >> > > are false positives report them to the maintainer, see >> > > CHECKPATCH in MAINTAINERS. >> >> It seems very unlikely all of the reported errors here can be >> justified >> along the lines of internal consistency, especially for adding a new >> file. > > It's actually an old thread ;-) I've already fixed some of these, just > haven't had a chance to finish and submit a new version. I'll blame my mailer for bringing old-threads up when new posts are made ;-) > > However *most* of the above are intentional and I won't fix, it's about > the .h file describing the registers that is essentially lifted from > Linux and that I want to keep largely identical for obvious reasons > (thus including the use of tabs). Unless it is highly likely you'll be re-importing changes it is a bit of a thin justification. For things like linux-headers we obviously already have a mechanism that allows for raw import of violating headers. In this case you are just grabbing a bunch of magic numbers that haven't been updated for at least 11 years (if not more, the numbers pre-date Linux's git history). But hey I'll happily defer to the maintainers on this one! -- Alex Bennée