From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bblNw-0007az-Fm for qemu-devel@nongnu.org; Mon, 22 Aug 2016 05:19:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bblNs-0004OF-68 for qemu-devel@nongnu.org; Mon, 22 Aug 2016 05:19:11 -0400 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:38731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bblNr-0004O2-Ho for qemu-devel@nongnu.org; Mon, 22 Aug 2016 05:19:08 -0400 Received: by mail-wm0-x22e.google.com with SMTP id o80so132873732wme.1 for ; Mon, 22 Aug 2016 02:19:07 -0700 (PDT) References: <20160819170025.22345-1-bobby.prani@gmail.com> <6167fa7a-2037-abdf-986e-be33747b51e4@twiddle.net> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Mon, 22 Aug 2016 10:19:14 +0100 Message-ID: <87fupxw48d.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH 0/4] Clean up TCG tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Pranith Kumar , Richard Henderson , qemu-devel , Paolo Bonzini Peter Maydell writes: > On 21 August 2016 at 04:46, Pranith Kumar wrote: >> The tests currently fail, so I didn't think it would be appropriate to >> hook them up. If the rearrangement is acceptable and once I fix the >> tests, I will hook up 'make check' to run these tests. > > So the question is: how will this work on systems which > don't have the relevant compiler toolchain for the target? > This has always been the stumbling block for tests which > want to run guest code: it's just too much of a pain for > most developers to have the toolchains available to build > the guest code. We could just make running the tests optional on ./configure finding the relevant cross compilers. The misc/ tests at the very least can be built with the host compiler and run on a host-to-host linux-user build. > > I have a vague idea that we could use something involving > docker images so that you could define a test case including > what the toolchain it needed to build was, and then have > images so that in practice you could just use prebuilt > binaries for the test blobs. But I haven't really thought > much about it yet. Currently the docker support doesn't allow copying artefacts from the build. But you can certainly run a make target in a (potentially) cross arch docker container now. For example: make docker-test-quick@debian-bootstrap \ EXTRA_CONFIGURE_OPTS="--enable-gprof --enable-gcov --disable-pie" \ J=9 V=1 DEBUG=1 If we fix up make test to build misc + host compiler directory then they will get run by the binfmt_misc enabled linux-user binary that was copied when the image was created. You can update the image with the current image easily enough: ./tests/docker/docker.py update qmu:debian-bootstrap ./arm-linux-user/qemu-arm > > thanks > -- PMM -- Alex Bennée