From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39302)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aJjim-0007xu-NK
	for qemu-devel@nongnu.org; Thu, 14 Jan 2016 10:21:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aJjii-00009x-Nx
	for qemu-devel@nongnu.org; Thu, 14 Jan 2016 10:21:56 -0500
Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:33585)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aJjii-00009j-Ih
	for qemu-devel@nongnu.org; Thu, 14 Jan 2016 10:21:52 -0500
Received: by mail-wm0-x234.google.com with SMTP id f206so351664181wmf.0
	for <qemu-devel@nongnu.org>; Thu, 14 Jan 2016 07:21:52 -0800 (PST)
References: <1452783202-576-1-git-send-email-peter.maydell@linaro.org>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1452783202-576-1-git-send-email-peter.maydell@linaro.org>
Date: Thu, 14 Jan 2016 15:21:49 +0000
Message-ID: <87fuy0chki.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] disas/libvixl: Really suppress gcc 4.6.3
	sign-compare warnings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, Franz-Josef Haider <Franz-Josef.Haider@student.uibk.ac.at>, qemu-devel@nongnu.org, patches@linaro.org


Peter Maydell <peter.maydell@linaro.org> writes:

> Commit 8acc216b956 attempted to silence some sign-compare
> warnings in libvixl by adding -Wno-sign-compare to the CFLAGS
> for the relevant objects. Unfortunately it was ineffective
> because it was placed before $(QEMU_CFLAGS), so the -Wall in
> the general flags overrode -Wno-sign-compare rather than
> vice-versa. Reorder the flags so the warning suppression works.
>
> Thanks to Franz-Josef Haider <Franz-Josef.Haider@student.uibk.ac.at>
> for pointing out what was wrong with the original patch.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Alex, is there a way to test this patch against Travis before
> we commit it to master?

Mea culpa:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

and a conditional:

Tested-by: Alex Bennée <alex.bennee@linaro.org>

when:

https://travis-ci.org/stsquad/qemu/builds/102371704

completes.

>
>  disas/libvixl/Makefile.objs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disas/libvixl/Makefile.objs b/disas/libvixl/Makefile.objs
> index d1e801a..bbe7695 100644
> --- a/disas/libvixl/Makefile.objs
> +++ b/disas/libvixl/Makefile.objs
> @@ -6,6 +6,6 @@ libvixl_OBJS = vixl/utils.o \
>
>  # The -Wno-sign-compare is needed only for gcc 4.6, which complains about
>  # some signed-unsigned equality comparisons which later gcc versions do not.
> -$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl -Wno-sign-compare $(QEMU_CFLAGS)
> +$(addprefix $(obj)/,$(libvixl_OBJS)): QEMU_CFLAGS := -I$(SRC_PATH)/disas/libvixl $(QEMU_CFLAGS) -Wno-sign-compare
>
>  common-obj-$(CONFIG_ARM_A64_DIS) += $(libvixl_OBJS)


--
Alex Bennée