From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46214)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1YD8L7-0004Ij-Rz
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 04:09:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1YD8L4-0004Ze-Cz
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 04:09:41 -0500
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:56251 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1YD8L4-0004Za-7G
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 04:09:38 -0500
References: <1421334118-3287-1-git-send-email-peter.maydell@linaro.org>
	<1421334118-3287-11-git-send-email-peter.maydell@linaro.org>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1421334118-3287-11-git-send-email-peter.maydell@linaro.org>
Date: Mon, 19 Jan 2015 09:09:52 +0000
Message-ID: <87fvb7qgpr.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 10/15] cpu_ldst.h: Remove unused very short
	ld*/st* defines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, patches@linaro.org, Richard Henderson <rth@twiddle.net>


Peter Maydell <peter.maydell@linaro.org> writes:

> The very short ld*/st* defines are now not used anywhere; delete them.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


> ---
>  include/exec/cpu_ldst.h | 26 --------------------------
>  1 file changed, 26 deletions(-)
>
> diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
> index 64d9087..2dc4775 100644
> --- a/include/exec/cpu_ldst.h
> +++ b/include/exec/cpu_ldst.h
> @@ -82,20 +82,6 @@
>  #if defined(CONFIG_USER_ONLY)
>  
>  /* if user mode, no other memory access functions */
> -#define ldub(p) ldub_raw(p)
> -#define ldsb(p) ldsb_raw(p)
> -#define lduw(p) lduw_raw(p)
> -#define ldsw(p) ldsw_raw(p)
> -#define ldl(p) ldl_raw(p)
> -#define ldq(p) ldq_raw(p)
> -#define ldfl(p) ldfl_raw(p)
> -#define ldfq(p) ldfq_raw(p)
> -#define stb(p, v) stb_raw(p, v)
> -#define stw(p, v) stw_raw(p, v)
> -#define stl(p, v) stl_raw(p, v)
> -#define stq(p, v) stq_raw(p, v)
> -#define stfl(p, v) stfl_raw(p, v)
> -#define stfq(p, v) stfq_raw(p, v)
>  
>  #define cpu_ldub_code(env1, p) ldub_raw(p)
>  #define cpu_ldsb_code(env1, p) ldsb_raw(p)
> @@ -287,18 +273,6 @@ uint64_t helper_ldq_cmmu(CPUArchState *env, target_ulong addr, int mmu_idx);
>  #undef CPU_MMU_INDEX
>  #undef MEMSUFFIX
>  
> -#define ldub(p) ldub_data(p)
> -#define ldsb(p) ldsb_data(p)
> -#define lduw(p) lduw_data(p)
> -#define ldsw(p) ldsw_data(p)
> -#define ldl(p) ldl_data(p)
> -#define ldq(p) ldq_data(p)
> -
> -#define stb(p, v) stb_data(p, v)
> -#define stw(p, v) stw_data(p, v)
> -#define stl(p, v) stl_data(p, v)
> -#define stq(p, v) stq_data(p, v)
> -
>  #define CPU_MMU_INDEX (cpu_mmu_index(env))
>  #define MEMSUFFIX _code
>  #define SOFTMMU_CODE_ACCESS

-- 
Alex Bennée