From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49979)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WkwIN-0001AZ-3O
	for qemu-devel@nongnu.org; Thu, 15 May 2014 10:06:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WkwII-0006gM-67
	for qemu-devel@nongnu.org; Thu, 15 May 2014 10:06:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56182)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WkwIH-0006fw-Vs
	for qemu-devel@nongnu.org; Thu, 15 May 2014 10:05:58 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <5374BC55.9020301@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?=
	=?utf-8?Q?'s?= message of "Thu, 15 May 2014 15:08:37 +0200")
References: <1400095810-27684-1-git-send-email-ehabkost@redhat.com>
	<1400095810-27684-17-git-send-email-ehabkost@redhat.com>
	<8738gb9r2d.fsf@elfo.mitica> <5374BC55.9020301@suse.de>
Date: Thu, 15 May 2014 16:05:44 +0200
Message-ID: <87fvkb87d3.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RESEND v4 16/18] savevm: check vmsd for
	migratability status
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org

Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> Am 15.05.2014 14:14, schrieb Juan Quintela:
>> Eduardo Habkost <ehabkost@redhat.com> wrote:
>>> From: Marcelo Tosatti <mtosatti@redhat.com>
>>>
>>> Check vmsd for unmigratable field, allowing migratibility status
>>> to be modified after vmstate_register.
>>>
>>> Cc: Juan Quintela <quintela@redhat.com>
>>> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>>> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>=20
>> I agree with the patch spirt, but what happens if we want to disable
>> migration in a device that has no VMSD?
>
> As the patch shows, no non-VMSD device setting no_migrate exists today.
> Do you expect any to appear? I'm rather seeing more and more devices
> getting converted to VMSD.

I want people to notice that.  As said, I hope that everything new uses
VMSD.

Later, Juan.