From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKUsX-00070l-J6 for qemu-devel@nongnu.org; Mon, 03 Mar 2014 10:34:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKUsO-0007Ky-Jk for qemu-devel@nongnu.org; Mon, 03 Mar 2014 10:34:05 -0500 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:53691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKUsO-0007J8-29 for qemu-devel@nongnu.org; Mon, 03 Mar 2014 10:33:56 -0500 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Mar 2014 21:03:53 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 3B6E3125803E for ; Mon, 3 Mar 2014 21:05:58 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s23FXh8u56885350 for ; Mon, 3 Mar 2014 21:03:44 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s23FXk8k007845 for ; Mon, 3 Mar 2014 21:03:46 +0530 From: "Aneesh Kumar K.V" In-Reply-To: <53121A4B.70308@gmail.com> References: <52EF68CA.9060604@gmail.com> <20140203103429.GB10408@redhat.com> <52EF71DC.3000309@gmail.com> <52F0C8BA.7020709@gmail.com> <20140204110631.GD5632@redhat.com> <52F0CD67.5070601@gmail.com> <87siry3l7t.fsf@linux.vnet.ibm.com> <52F17B5E.1050602@gmail.com> <52FF3182.9090106@gmail.com> <53097D8E.1030803@gmail.com> <87sir850ho.fsf@blackfin.pond.sub.org> <87ha7o3c5x.fsf@blackfin.pond.sub.org> <530FCBAD.10305@gmail.com> <531219CC.4050505@gmail.com> <53121A12.5050105@gmail.com> <53121A4B.70308@gmail.com> Date: Mon, 03 Mar 2014 21:03:45 +0530 Message-ID: <87fvmzxpnq.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Gang , Markus Armbruster , aliguori@amazon.com, Eric Blake , "Daniel P. Berrange" Cc: QEMU Developers Chen Gang writes: > 'ctx->fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so > need use snprintf() instead of sprintf() just like another area have done in 9pfs. > > Signed-off-by: Chen Gang Will take care of Markus feedback. Reviewed-by: Aneesh Kumar K.V > --- > hw/9pfs/virtio-9p-local.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c > index 77a04cd..61be75a 100644 > --- a/hw/9pfs/virtio-9p-local.c > +++ b/hw/9pfs/virtio-9p-local.c > @@ -898,7 +898,8 @@ static int local_remove(FsContext *ctx, const char *path) > * directory > */ > if (S_ISDIR(stbuf.st_mode)) { > - sprintf(buffer, "%s/%s/%s", ctx->fs_root, path, VIRTFS_META_DIR); > + snprintf(buffer, ARRAY_SIZE(buffer), "%s/%s/%s", > + ctx->fs_root, path, VIRTFS_META_DIR); > err = remove(buffer); > if (err < 0 && errno != ENOENT) { > /* > @@ -1033,8 +1034,8 @@ static int local_unlinkat(FsContext *ctx, V9fsPath *dir, > * If directory remove .virtfs_metadata contained in the > * directory > */ > - sprintf(buffer, "%s/%s/%s", ctx->fs_root, > - fullname.data, VIRTFS_META_DIR); > + snprintf(buffer, ARRAY_SIZE(buffer), "%s/%s/%s", ctx->fs_root, > + fullname.data, VIRTFS_META_DIR); > ret = remove(buffer); > if (ret < 0 && errno != ENOENT) { > /* > -- > 1.7.11.7