From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47993)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1V7QKF-0007BV-M3
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 09:32:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1V7QK9-0003KY-H4
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 09:32:23 -0400
Received: from mail-ie0-f179.google.com ([209.85.223.179]:53372)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1V7QK9-0003KQ-Ch
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 09:32:17 -0400
Received: by mail-ie0-f179.google.com with SMTP id c11so1801350ieb.38
	for <qemu-devel@nongnu.org>; Thu, 08 Aug 2013 06:32:16 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <1375938949-22622-5-git-send-email-rusty@rustcorp.com.au>
References: <1375938949-22622-1-git-send-email-rusty@rustcorp.com.au>
	<1375938949-22622-5-git-send-email-rusty@rustcorp.com.au>
Date: Thu, 08 Aug 2013 08:32:14 -0500
Message-ID: <87fvukgvfl.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 4/7] hw/net/virtio-balloon: use virtio
	wrappers to access page frame numbers.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org

Rusty Russell <rusty@rustcorp.com.au> writes:

> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>  hw/virtio/virtio-balloon.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> index d669756..c0b4f6e 100644
> --- a/hw/virtio/virtio-balloon.c
> +++ b/hw/virtio/virtio-balloon.c
> @@ -30,6 +30,7 @@
>  #endif
>  
>  #include "hw/virtio/virtio-bus.h"
> +#include "hw/virtio/virtio-access.h"
>  
>  static void balloon_page(void *addr, int deflate)
>  {
> @@ -192,7 +193,7 @@ static void virtio_balloon_handle_output(VirtIODevice *vdev, VirtQueue *vq)
>              ram_addr_t pa;
>              ram_addr_t addr;
>  
> -            pa = (ram_addr_t)ldl_p(&pfn) << VIRTIO_BALLOON_PFN_SHIFT;
> +            pa = (ram_addr_t)virtio_ldl_p(&pfn) << VIRTIO_BALLOON_PFN_SHIFT;
>              offset += 4;
>  
>              /* FIXME: remove get_system_memory(), but how? */
> -- 
> 1.8.1.2