From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfBcy-0003iZ-Dw for qemu-devel@nongnu.org; Wed, 22 May 2013 12:11:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfBct-0005iP-47 for qemu-devel@nongnu.org; Wed, 22 May 2013 12:11:00 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:42895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfBcr-0005i2-W1 for qemu-devel@nongnu.org; Wed, 22 May 2013 12:10:54 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 23 May 2013 02:04:18 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 7B1E12CE804D for ; Thu, 23 May 2013 02:10:46 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4MFuSrF16777400 for ; Thu, 23 May 2013 01:56:28 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4MGAjIo016487 for ; Thu, 23 May 2013 02:10:45 +1000 From: Anthony Liguori In-Reply-To: References: <1369066884-431-1-git-send-email-peter.maydell@linaro.org> <519A50EE.8040804@redhat.com> <871u8zp34w.fsf@codemonkey.ws> <519CCD21.8090008@suse.de> <871u8zjdgy.fsf@codemonkey.ws> <519CD77B.3080400@suse.de> <87mwrncbok.fsf@codemonkey.ws> Date: Wed, 22 May 2013 11:10:25 -0500 Message-ID: <87fvxfov0u.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] New targets (was: [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , John Rigby , Andreas =?utf-8?Q?F=C3=A4rber?= , qemu-devel@nongnu.org Peter Maydell writes: > On 22 May 2013 15:48, Anthony Liguori wrote: >> Andreas F=C3=A4rber writes: >>> Am 22.05.2013 16:28, schrieb Anthony Liguori: >>> So are incompletely implemented targets (wrt instruction set) eligible >>> for upstream these days? >> >> Aren't most of our target incomplete by some standard? >> >> I thought the typical approach for a target was to get linux-user >> working first, and then go for softmmu. As long as linux-user can run >> application, I think it's fair game for merging. >> >>> I thought they'd need to be able to run at >>> least some small image successfully, preferably Linux where possible. >> >> I think that's far too high of a hurdle. > > I think the bar should probably be at about "either can run some > plausible set of Linux binaries in user mode, or can run some > softmmu image (eg linux with a minimal config", whichever the > target submitter prefers. Basically something plausibly useful > to somebody other than the developer. Another way to put this, and this is true for *all* contributions, is that the bar for acceptance is whether something is useful even if the submitter immediately stopped contributing after the patch was merged. Regards, Anthony Liguori > > thanks > -- PMM