From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCdnr-0003XU-JQ for qemu-devel@nongnu.org; Mon, 04 Mar 2013 17:24:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCdnq-0000lM-HQ for qemu-devel@nongnu.org; Mon, 04 Mar 2013 17:24:15 -0500 Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:45006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCdnq-0000kX-Cv for qemu-devel@nongnu.org; Mon, 04 Mar 2013 17:24:14 -0500 Received: by mail-ob0-f169.google.com with SMTP id ta14so2258683obb.0 for ; Mon, 04 Mar 2013 14:24:13 -0800 (PST) From: Anthony Liguori In-Reply-To: <513518B9.5000400@redhat.com> References: <512FF819.7050505@redhat.com> <87k3pqzy2y.fsf@codemonkey.ws> <513110D3.5030503@linux.vnet.ibm.com> <87d2vig75m.fsf@codemonkey.ws> <51311A13.6030205@redhat.com> <87r4jy90wt.fsf@codemonkey.ws> <51313660.5010001@redhat.com> <87vc9apt7r.fsf@codemonkey.ws> <513147E4.5030005@redhat.com> <87txouv6hp.fsf@codemonkey.ws> <5131EF32.5010808@redhat.com> <874ngs9ou2.fsf@codemonkey.ws> <513518B9.5000400@redhat.com> Date: Mon, 04 Mar 2013 16:24:04 -0600 Message-ID: <87fw0aregr.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] virtio-rng and fd passing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: "libvir-list@redhat.com" , Paolo Bonzini , "qemu-devel@nongnu.org" , Stefan Berger Eric Blake writes: > [adding libvirt] > > On 03/03/2013 02:05 PM, Anthony Liguori wrote: >> Paolo Bonzini writes: >> >>> Il 02/03/2013 04:13, Anthony Liguori ha scritto: >>>> There is no valid use-case of rng-random other than using /dev/random. >>>> In fact, it was probably a mistake to even allow a filename to be >>>> specified because it lets people do silly things (like /dev/urandom). >>>> >>>> If you want anything other than /dev/random, you should use rng-egd. >>> >>> /dev/hwrng makes sense too. >> >> Good point. Perhaps we should issue a warning when anything is used >> other than /dev/random or /dev/hwrng to discourage people from doing the >> wrong thing. I completely understand the confusion and I think we >> should try a bit harder to prevent people from getting it wrong. > > Then libvirt should also make sure that the XML we allow for non-egd > virtio-rng is restricted to the two filenames that won't cause a qemu > warning, or even modify the XML to not expose a filename in the first > place. We haven't released libvirt 1.0.3 yet, so we still have a few > hours in which such a change could be made before the XML becomes baked > by a release. We've already released QEMU accepting any file name so we can't remove that functionality but I'm very much leaning toward producing such a warning for 1.5. It's such an easy mistake to make and it's extremely difficult to find good information on what you should and shouldn't do. I think that we (QEMU and libvirt) should try hard to steer people in the right direction. Regards, Anthony Liguori > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org