From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJQ7v-0000Li-P5 for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:40:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJQ7n-0001SF-16 for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:40:43 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:48983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJQ7m-0001OJ-Sc for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:40:34 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Oct 2012 10:40:25 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q93EeNm5141184 for ; Wed, 3 Oct 2012 10:40:23 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q93EeNAi002810 for ; Wed, 3 Oct 2012 10:40:23 -0400 From: Anthony Liguori In-Reply-To: <20121003105509.391284251@amt.cnet> References: <20121003105255.972669952@amt.cnet> <20121003105509.391284251@amt.cnet> Date: Wed, 03 Oct 2012 09:40:17 -0500 Message-ID: <87fw5vhb5a.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti , qemu-devel@nongnu.org, Gerd Hoffmann Cc: kvm@vger.kernel.org Marcelo Tosatti writes: > Commit 3ad763fcba5bd0ec5a79d4a9b6baeef119dd4a3d from qemu-kvm.git. > > From: Jan Kiszka > > Upstream is moving towards this mechanism, so start using it in qemu-kvm > already to configure the specific defaults: kvm enabled on, just like > in-kernel irqchips. > > Signed-off-by: Marcelo Tosatti Reviewed-by: Anthony Liguori Although it's a little odd to have From: Jan without a SoB... Regards, Anthony Liguori > > Index: qemu-compat-kvm/vl.c > =================================================================== > --- qemu-compat-kvm.orig/vl.c > +++ qemu-compat-kvm/vl.c > @@ -3061,6 +3061,12 @@ int main(int argc, char **argv, char **e > machine = machine_parse(optarg); > } > break; > + case QEMU_OPTION_no_kvm_irqchip: { > + olist = qemu_find_opts("machine"); > + qemu_opts_parse(olist, "kernel_irqchip=off", 0); > + break; > + } > + > case QEMU_OPTION_usb: > usb_enabled = 1; > break; > Index: qemu-compat-kvm/qemu-options.hx > =================================================================== > --- qemu-compat-kvm.orig/qemu-options.hx > +++ qemu-compat-kvm/qemu-options.hx > @@ -2838,6 +2838,10 @@ STEXI > Enable FIPS 140-2 compliance mode. > ETEXI > > +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, > + "-no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC\n", > + QEMU_ARCH_I386) > + > HXCOMM This is the last statement. Insert new options before this line! > STEXI > @end table > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html