From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxPmH-00074V-6t for qemu-devel@nongnu.org; Fri, 03 Aug 2012 17:51:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxPfx-0003zP-Vw for qemu-devel@nongnu.org; Fri, 03 Aug 2012 17:45:10 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:41024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxPfx-0003zB-Me for qemu-devel@nongnu.org; Fri, 03 Aug 2012 17:44:53 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Aug 2012 15:44:48 -0600 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 456D01FF001E for ; Fri, 3 Aug 2012 21:44:04 +0000 (WET) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q73LhRDY139378 for ; Fri, 3 Aug 2012 15:43:27 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q73LhQDr007310 for ; Fri, 3 Aug 2012 15:43:26 -0600 From: Anthony Liguori In-Reply-To: <501C2D04.5020205@redhat.com> References: <1343981180-23817-1-git-send-email-pbonzini@redhat.com> <501C261E.40406@us.ibm.com> <501C2D04.5020205@redhat.com> Date: Fri, 03 Aug 2012 16:43:23 -0500 Message-ID: <87fw83veh0.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PULL 00/10] SCSI patches for 2012-08-03 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Blue Swirl , Herve Poussineau , qemu-devel@nongnu.org Paolo Bonzini writes: > Il 03/08/2012 21:27, Anthony Liguori ha scritto: >> On 08/03/2012 03:06 AM, Paolo Bonzini wrote: >>> Anthony, >>> >>> The following changes since commit >>> 5e3bc7144edd6e4fa2824944e5eb16c28197dd5a: >>> >>> Merge remote-tracking branch 'mst/tags/for_anthony' into staging >>> (2012-07-30 10:00:48 -0500) >>> >>> are available in the git repository at: >>> >>> >>> git://github.com/bonzini/qemu.git scsi-next >>> >>> for you to fetch changes up to b71760ef6180662cc2dff1f6cf673a53508c59f1: >>> >>> scsi: add support for ATA_PASSTHROUGH_xx scsi command (2012-08-03 >>> 10:04:37 +0200) >>> >>> The main change here is re-enabling megasas, but there's also Herve's >>> retro HBA and a couple of random fixes. >> >> CC sparc-softmmu/target-sparc/mmu_helper.o >> CC sparc-softmmu/target-sparc/ldst_helper.o >> CC sparc-softmmu/target-sparc/int32_helper.o >> LINK sparc-softmmu/qemu-system-sparc >> ../libhw64/hw/esp.o: In function `dc390_read_config': >> /home/anthony/git/qemu/hw/esp.c:1220: undefined reference to >> `pci_default_read_config' >> ../libhw64/hw/esp.o: In function `dc390_write_config': >> /home/anthony/git/qemu/hw/esp.c:1245: undefined reference to >> `pci_default_write_config' >> collect2: ld returned 1 exit status >> make[1]: *** [qemu-system-sparc] Error 1 >> make: *** [subdir-sparc-softmmu] Error 2 >> >> It looks like sparc does link in esp.c but doesn't support pci (at least >> pci.o). I must admit, it's not obvious to me whether pci.o should be >> added to the sparc build or whether esp.c needs to be refactored. > > I think the latter. > > I removed this patch and pushed the rest (commit e4b6526) at the same > location. Blue/Herve, can you look at esp.c? Pulled. Thanks. Regards, Anthony Liguori > > Paolo