From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MsP2v-0004lc-5x
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 18:50:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MsP2q-0004kJ-M0
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 18:50:16 -0400
Received: from [199.232.76.173] (port=51944 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MsP2q-0004kF-91
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 18:50:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32370)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1MsP2p-0000mo-R5
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 18:50:12 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8SMoAuW022504
	for <qemu-devel@nongnu.org>; Mon, 28 Sep 2009 18:50:11 -0400
Subject: Re: [Qemu-devel] [RfC PATCH 0/3] qdev-ify network cards
References: <1253907783-1231-1-git-send-email-kraxel@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 29 Sep 2009 00:50:09 +0200
In-Reply-To: <1253907783-1231-1-git-send-email-kraxel@redhat.com> (Gerd
	Hoffmann's message of "Fri\, 25 Sep 2009 21\:43\:00 +0200")
Message-ID: <87fxa6bs66.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> writes:

>   Hi,
>
> Short RfC patch series to get the discussion rolling.  We really need to
> get the nic drivers qdev-ified properly, so qemu stops segfaulting on
> '-device $any_nic_here'.
>
> To keep things small simple I've started with the ne2k_isa.  All the PCI
> nics share the initialization path and thus I can't simply pick a single
> one as example and convert it.
>
> The network card can now be created using ...
>
>   -device ne2k_isa,mac=00:11:22:33:44:55,vlan=0,irq=3,id=foo
[...]
>
> The nic initialization code calls qemu_new_vlan_client() with the
> vlan specified using the vlan property.  Likewise the device cleanup
> code should call qemu_del_vlan_client.  You don't see that in the
> patches though as ISA devices are not hot-pluggable ;)
>
> struct NICInfo is not needed at all here.  I hope we can kill it long-term.

That would be good.

> This patch series is also available here:
>   http://git.et.redhat.com/?p=qemu-kraxel.git;a=shortlog;h=refs/heads/nic.v1
>
> You might find it useful to have a look at the qbus patches.  Especially
> the hotplug patches which add device_add and device_del monitor
> commands.  The patches are on the qemu-devel list too and also here:
>    http://git.et.redhat.com/?p=qemu-kraxel.git;a=shortlog;h=refs/heads/qbus.v2

Patches look fine to me.