Re: [PATCH v2 1/7] tests/migration-test: Add multifd+postcopy test for preempt recovery

[Fabiano Rosas <farosas@suse.de>]

Peter Xu <peterx@redhat.com> writes:

> We have one for TLS, but we don't have the non-TLS version.  Add it.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  tests/qtest/migration/postcopy-tests.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/tests/qtest/migration/postcopy-tests.c b/tests/qtest/migration/postcopy-tests.c
> index 13a5759655..6c4fd31152 100644
> --- a/tests/qtest/migration/postcopy-tests.c
> +++ b/tests/qtest/migration/postcopy-tests.c
> @@ -89,6 +89,15 @@ static void test_multifd_postcopy_preempt(char *name, MigrateCommon *args)
>      test_postcopy_common(args);
>  }
>  
> +static void test_multifd_postcopy_preempt_recovery(char *name,
> +                                                   MigrateCommon *args)
> +{
> +    args->start.caps[MIGRATION_CAPABILITY_MULTIFD] = true;
> +    args->start.caps[MIGRATION_CAPABILITY_POSTCOPY_PREEMPT] = true;
> +
> +    test_postcopy_recovery_common(args, POSTCOPY_FAIL_NONE);
> +}
> +
>  void migration_test_add_postcopy(MigrationTestEnv *env)
>  {
>      migration_test_add_postcopy_smoke(env);
> @@ -113,6 +122,8 @@ void migration_test_add_postcopy(MigrationTestEnv *env)
>                             test_multifd_postcopy);
>          migration_test_add("/migration/multifd+postcopy/preempt/plain",
>                             test_multifd_postcopy_preempt);
> +        migration_test_add("/migration/multifd+postcopy/preempt/recovery/plain",
> +                           test_multifd_postcopy_preempt_recovery);
>          if (env->is_x86) {
>              migration_test_add("/migration/postcopy/suspend",
>                                 test_postcopy_suspend);

Reviewed-by: Fabiano Rosas <farosas@suse.de>