qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@suse.de>
To: Yuan Liu <yuan1.liu@intel.com>,
	peterx@redhat.com, pbonzini@redhat.com,
	marcandre.lureau@redhat.com, berrange@redhat.com,
	thuth@redhat.com, philmd@linaro.org
Cc: qemu-devel@nongnu.org, yuan1.liu@intel.com, nanhai.zou@intel.com,
	shameerali.kolothum.thodi@huawei.com
Subject: Re: [PATCH v8 4/7] migration/multifd: add qpl compression method
Date: Wed, 12 Jun 2024 11:31:24 -0300	[thread overview]
Message-ID: <87h6dycjwj.fsf@suse.de> (raw)
In-Reply-To: <87msnqck32.fsf@suse.de>

Fabiano Rosas <farosas@suse.de> writes:

> Yuan Liu <yuan1.liu@intel.com> writes:
>
>> add the Query Processing Library (QPL) compression method
>>
>> Introduce the qpl as a new multifd migration compression method, it can
>> use In-Memory Analytics Accelerator(IAA) to accelerate compression and
>> decompression, which can not only reduce network bandwidth requirement
>> but also reduce host compression and decompression CPU overhead.
>>
>> How to enable qpl compression during migration:
>> migrate_set_parameter multifd-compression qpl
>>
>> There is no qpl compression level parameter added since it only supports
>> level one, users do not need to specify the qpl compression level.
>>
>> Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
>> Reviewed-by: Nanhai Zou <nanhai.zou@intel.com>
>> Reviewed-by: Peter Xu <peterx@redhat.com>
>> Reviewed-by: Fabiano Rosas <farosas@suse.de>
>
> I don't think I ever reviewed this patch. Please drop this when you
> resubmit.

Actually, just leave it. I thought you'd need to fix the output size on
6/7, but I saw you just moved it elsewhere. So no need to respin. I'll
queue this version shortly unless anyone else has comments.


  reply	other threads:[~2024-06-12 14:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 10:21 [PATCH v8 0/7] Live Migration With IAA Yuan Liu
2024-06-10 10:21 ` [PATCH v8 1/7] docs/migration: add qpl compression feature Yuan Liu
2024-06-10 10:21 ` [PATCH v8 2/7] migration/multifd: put IOV initialization into compression method Yuan Liu
2024-06-10 10:21 ` [PATCH v8 3/7] configure: add --enable-qpl build option Yuan Liu
2024-06-10 10:21 ` [PATCH v8 4/7] migration/multifd: add qpl compression method Yuan Liu
2024-06-12 14:27   ` Fabiano Rosas
2024-06-12 14:31     ` Fabiano Rosas [this message]
2024-06-13  1:06       ` Liu, Yuan1
2024-06-13  0:58     ` Liu, Yuan1
2024-06-10 10:21 ` [PATCH v8 5/7] migration/multifd: implement initialization of qpl compression Yuan Liu
2024-06-10 10:21 ` [PATCH v8 6/7] migration/multifd: implement qpl compression and decompression Yuan Liu
2024-06-12 14:29   ` Fabiano Rosas
2024-06-10 10:21 ` [PATCH v8 7/7] tests/migration-test: add qpl compression test Yuan Liu
2024-06-14 13:01 ` [PATCH v8 0/7] Live Migration With IAA Fabiano Rosas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6dycjwj.fsf@suse.de \
    --to=farosas@suse.de \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=nanhai.zou@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=thuth@redhat.com \
    --cc=yuan1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).