From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76BF8C001DB for ; Mon, 14 Aug 2023 11:34:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVVpT-0002Hs-CY; Mon, 14 Aug 2023 07:33:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVVpR-0002DX-KO for qemu-devel@nongnu.org; Mon, 14 Aug 2023 07:33:45 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVVpN-0002ht-AP for qemu-devel@nongnu.org; Mon, 14 Aug 2023 07:33:45 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fe2ba3e260so41439135e9.2 for ; Mon, 14 Aug 2023 04:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692012819; x=1692617619; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=XEAMLvLm/QGafb1baWyDmF4nCxSk4CBVzHW3q+MmcBs=; b=v54GtK1RJXF/m86pofd/o4jEIVlxz93s/8eHwvrzWGJlHEFyfmvAVmj9sHqsXpbpXk 6zu0mMJK6rFiwzLT55dNkwMOk1hkFR7VE6vbFA7btJE0Wlv83LGFuR6q+xlbdehQMGtR GqPY+ULIP2B1aOnxNrcExzgSxDa0Lulrac+ZLd2v1gHJl3da0hX5P0dtXXgAwG8LpK3C MTcnktBsE3CJvRbfch4YjdG0FCy+u9wrVPwlKkJtpvMVjTGCtKQxC3UeSnvFgldwf8AA aD5Gmqyczp3Qv50uR2QSTWkcPBJNvhTKJV9CPHh7owam80eexkvWMU5Vtjz4a6kGFHLE d1QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692012819; x=1692617619; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XEAMLvLm/QGafb1baWyDmF4nCxSk4CBVzHW3q+MmcBs=; b=cYLtZJwza9DhS3LZl0UZPVuP5HHzM2/MFRSeTCt4KtwmaCS18HX91GT5XSVqwLwMHv SEFwlXHSbVJRUrcYDWHvtI5mSSLA9ekKYicSiSYvAyh1VDwBOgrpfESkosTG3Qq4wlpN Ww/dvjr0z7OoSS1JD/QYwNIlpKaHsff6nAVufrpUVwuRYPbHXMZAqAOvNmPZCqBrUlIg kATljlCRWhw3X8V/owNKXhYNqMAPZ4ORg5YbFAIR6rFZzWlbaI8RIAdH5xFGQvgPn348 MsesUzOuwOTFbQDevZT7xAI5j8BRa736ayRFCyj7HkuSZlE8djlLtptiFFWGjndiXRKi WYFQ== X-Gm-Message-State: AOJu0YxN1qdaA8UOSvy6GcLM2ddVOv9f5lipSEAIInHxXw2nvg9ReEt8 q0ixC6UUMhlsF2YH2NznUaflMA== X-Google-Smtp-Source: AGHT+IHLFtAyBhJ6WE/UHd6BT/WzSJU/T1peIDJ+zjhYCSL1p6elo7duHN4RCAGeGMik2cL2GKLRRg== X-Received: by 2002:a7b:c445:0:b0:3f7:4961:52ad with SMTP id l5-20020a7bc445000000b003f7496152admr7197217wmi.3.1692012818941; Mon, 14 Aug 2023 04:33:38 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id q11-20020adff94b000000b00317c742ca9asm13915811wrr.43.2023.08.14.04.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 04:33:38 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1CE8F1FFBB; Mon, 14 Aug 2023 12:33:38 +0100 (BST) References: <20230731084354.115015-1-akihiko.odaki@daynix.com> <20230731084354.115015-3-akihiko.odaki@daynix.com> User-agent: mu4e 1.11.14; emacs 29.1.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Akihiko Odaki Cc: Paolo Bonzini , Thomas Huth , Alexandre Iooss , Mahmoud Mandour , Eduardo Habkost , Marcel Apfelbaum , Philippe =?utf-8?Q?Mathieu-Daud?= =?utf-8?Q?=C3=A9?= , Yanan Wang , Richard Henderson , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , =?utf-8?Q?Daniel_P=2E_Berrang=C3=A9?= , John Snow , Cleber Rosa , Peter Maydell , Michael Rolnik , "Edgar E. Iglesias" , Brian Cain , Song Gao , Xiaojuan Yang , Laurent Vivier , Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo , Chris Wulff , Marek Vasut , Stafford Horne , Daniel Henrique Barboza , =?utf-8?Q?C=C3=A9dric?= Le Goater , David Gibson , Greg Kurz , Nicholas Piggin , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Liu Zhiwei , Yoshinori Sato , David Hildenbrand , Ilya Leoshkevich , Mark Cave-Ayland , Artyom Tarasenko , Bastian Koppelmann , Max Filippov , qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org Subject: Re: [RFC PATCH 02/24] gdbstub: Introduce GDBFeature structure Date: Mon, 14 Aug 2023 12:33:17 +0100 In-reply-to: <20230731084354.115015-3-akihiko.odaki@daynix.com> Message-ID: <87h6p1svsd.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Akihiko Odaki writes: > Before this change, the information from a XML file was stored in an > array that is not descriptive. Introduce a dedicated structure type to > make it easier to understand and to extend with more fields. > > Signed-off-by: Akihiko Odaki with Phillipe's suggested updates: Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro