From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org,
"Leonardo Bras Soares Passos" <lsoaresp@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v3] migration: Allow postcopy_ram_supported_by_host() to report err
Date: Wed, 26 Apr 2023 18:26:17 +0200 [thread overview]
Message-ID: <87h6t2fw46.fsf@secure.mitica> (raw)
In-Reply-To: <20230426011514.1972344-1-peterx@redhat.com> (Peter Xu's message of "Tue, 25 Apr 2023 21:15:14 -0400")
Peter Xu <peterx@redhat.com> wrote:
> Instead of print it to STDERR, bring the error upwards so that it can be
> reported via QMP responses.
>
> E.g.:
>
> { "execute": "migrate-set-capabilities" ,
> "arguments": { "capabilities":
> [ { "capability": "postcopy-ram", "state": true } ] } }
>
> { "error":
> { "class": "GenericError",
> "desc": "Postcopy is not supported: Host backend files need to be TMPFS
> or HUGETLBFS only" } }
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued.
prev parent reply other threads:[~2023-04-26 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 1:15 [PATCH v3] migration: Allow postcopy_ram_supported_by_host() to report err Peter Xu
2023-04-26 16:26 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6t2fw46.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=berrange@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).