From: Florian Weimer <fweimer@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
thuth@redhat.com, Daniel Berrange <berrange@redhat.com>,
qemu-block@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Warner Losh <imp@bsdimp.com>,
sguelton@redhat.com
Subject: Re: [RFC v2 1/4] tls: add macros for coroutine-safe TLS variables
Date: Wed, 01 Dec 2021 19:24:33 +0100 [thread overview]
Message-ID: <87h7bs6v4u.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20211201170120.286139-2-stefanha@redhat.com> (Stefan Hajnoczi's message of "Wed, 1 Dec 2021 17:01:17 +0000")
* Stefan Hajnoczi:
> +#elif defined(__x86_64__)
> +#define QEMU_CO_TLS_ADDR(ret, var) \
> + asm volatile("rdfsbase %0\n\t" \
> + "lea "#var"@tpoff(%0), %0" : "=r"(ret))
> +#endif
RDFSBASE needs quite recent kernels. I think you should use
movq %%fs:0, %0
instead, which is equivalent for the x86-64 psABI.
Thanks,
Florian
next prev parent reply other threads:[~2021-12-01 18:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 17:01 [RFC v2 0/4] tls: add macros for coroutine-safe TLS variables Stefan Hajnoczi
2021-12-01 17:01 ` [RFC v2 1/4] " Stefan Hajnoczi
2021-12-01 18:24 ` Florian Weimer [this message]
2021-12-02 9:53 ` Stefan Hajnoczi
2021-12-02 14:44 ` Peter Maydell
2021-12-02 14:50 ` Peter Maydell
2021-12-02 14:57 ` Florian Weimer
2021-12-03 6:24 ` Serge Guelton
2021-12-01 17:01 ` [RFC v2 2/4] util/async: replace __thread with QEMU TLS macros Stefan Hajnoczi
2021-12-01 17:01 ` [RFC v2 3/4] rcu: use coroutine " Stefan Hajnoczi
2021-12-01 17:01 ` [RFC v2 4/4] cpus: use coroutine TLS macros for iothread_locked Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7bs6v4u.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=berrange@redhat.com \
--cc=fam@euphon.net \
--cc=imp@bsdimp.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sguelton@redhat.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).