* [PATCH] ebpf: really include it only in system emulators
@ 2021-10-12 16:22 Paolo Bonzini
2021-10-12 16:41 ` Richard Henderson
2021-10-15 15:57 ` Alex Bennée
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-10-12 16:22 UTC (permalink / raw)
To: qemu-devel; +Cc: jasowang, Alex Bennée
eBPF libraries are being included in user emulators, which is useless and
also breaks --static compilation if a shared library for libbpf is
present in the system.
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
meson.build | 2 --
1 file changed, 2 deletions(-)
diff --git a/meson.build b/meson.build
index ca7b9d60af..6b7487b725 100644
--- a/meson.build
+++ b/meson.build
@@ -2595,8 +2595,6 @@ subdir('bsd-user')
subdir('linux-user')
subdir('ebpf')
-common_ss.add(libbpf)
-
bsd_user_ss.add(files('gdbstub.c'))
specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ebpf: really include it only in system emulators
2021-10-12 16:22 [PATCH] ebpf: really include it only in system emulators Paolo Bonzini
@ 2021-10-12 16:41 ` Richard Henderson
2021-10-15 15:57 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2021-10-12 16:41 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: jasowang, Alex Bennée
On 10/12/21 9:22 AM, Paolo Bonzini wrote:
> eBPF libraries are being included in user emulators, which is useless and
> also breaks --static compilation if a shared library for libbpf is
> present in the system.
>
> Reported-by: Alex Bennée<alex.bennee@linaro.org>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> meson.build | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ebpf: really include it only in system emulators
2021-10-12 16:22 [PATCH] ebpf: really include it only in system emulators Paolo Bonzini
2021-10-12 16:41 ` Richard Henderson
@ 2021-10-15 15:57 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2021-10-15 15:57 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: jasowang, qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> eBPF libraries are being included in user emulators, which is useless and
> also breaks --static compilation if a shared library for libbpf is
> present in the system.
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> meson.build | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index ca7b9d60af..6b7487b725 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2595,8 +2595,6 @@ subdir('bsd-user')
> subdir('linux-user')
> subdir('ebpf')
>
> -common_ss.add(libbpf)
> -
> bsd_user_ss.add(files('gdbstub.c'))
> specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-15 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-12 16:22 [PATCH] ebpf: really include it only in system emulators Paolo Bonzini
2021-10-12 16:41 ` Richard Henderson
2021-10-15 15:57 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).