From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4
Date: Thu, 26 Nov 2020 13:13:10 +0000 [thread overview]
Message-ID: <87h7pcgt21.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA8QqAq=+UQ2m7ztD7-Qh6y0YJ=qY3koabX7koWi-9b_MA@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On Thu, 26 Nov 2020 at 12:12, Daniel P. Berrangé <berrange@redhat.com> wrote:
>> On Thu, Nov 26, 2020 at 11:57:14AM +0000, Peter Maydell wrote:
>> > This is an interesting case, because it's a header intended
>> > for external use (people compiling plugins), not part of
>> > QEMU proper. I don't know whether we want to impose the
>> > same clang/gcc requirements on plugin builders, though it's
>> > probably not a bad idea to do so. Alex ?
>>
>> IIUC, we expect that the plugins are built specifically to go with
>> the QEMU you have built.
>
> No, the point of the plugin interface is that it actually is
> a (constrained) stable ABI with version-querying and checking
> so you don't have to build a plugin against the exact matching
> QEMU version. (But "don't use really ancient gcc" doesn't seem
> like a very major thing to ask of its users.)
Quite. But I agree using a GCC from this decade seems reasonable
especially as the feature has only been in QEMU for a few cycles.
Acked-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2020-11-26 13:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 11:29 [PATCH v2 00/13] Remove GCC < 4.8 checks marcandre.lureau
2020-11-26 11:29 ` [PATCH v2 01/13] compiler.h: replace QEMU_GNUC_PREREQ macro marcandre.lureau
2020-11-26 11:48 ` Peter Maydell
2020-11-26 11:55 ` Marc-André Lureau
2020-11-26 11:29 ` [PATCH v2 02/13] qemu/atomic: Drop special case for unsupported compiler marcandre.lureau
2020-11-26 11:49 ` Peter Maydell
2020-11-26 12:06 ` Daniel P. Berrangé
2020-11-26 12:13 ` Peter Maydell
2020-12-10 13:17 ` Marc-André Lureau
2020-12-10 13:42 ` Daniel P. Berrangé
2020-12-10 13:50 ` Daniel P. Berrangé
2020-11-26 11:29 ` [PATCH v2 03/13] accel/tcg: Remove special case for GCC < 4.6 marcandre.lureau
2020-11-26 11:29 ` [PATCH v2 04/13] compiler.h: remove GCC < 3 __builtin_expect fallback marcandre.lureau
2020-11-26 11:55 ` Peter Maydell
2020-12-10 13:35 ` Marc-André Lureau
2020-11-26 11:29 ` [PATCH v2 05/13] qemu-plugin.h: remove GCC < 4 marcandre.lureau
2020-11-26 11:57 ` Peter Maydell
2020-11-26 12:12 ` Daniel P. Berrangé
2020-11-26 12:14 ` Peter Maydell
2020-11-26 13:13 ` Alex Bennée [this message]
2020-11-26 11:29 ` [PATCH v2 06/13] tests: remove GCC < 4 fallbacks marcandre.lureau
2020-11-26 11:58 ` Peter Maydell
2020-11-27 13:10 ` Alex Bennée
2020-11-26 11:29 ` [PATCH v2 07/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON marcandre.lureau
2020-11-26 11:29 ` [PATCH v2 08/13] compiler.h: explicit case for Clang printf attribute marcandre.lureau
2020-11-26 12:00 ` Peter Maydell
2020-11-26 11:29 ` [PATCH v2 09/13] audio: remove GNUC & MSVC check marcandre.lureau
2020-11-26 12:06 ` Peter Maydell
2020-11-26 12:09 ` Marc-André Lureau
2020-11-27 7:15 ` Gerd Hoffmann
2020-11-27 7:20 ` Marc-André Lureau
2020-11-26 11:29 ` [PATCH v2 10/13] poison: remove GNUC check marcandre.lureau
2020-11-26 12:06 ` Peter Maydell
2020-11-26 11:29 ` [PATCH v2 11/13] xen: " marcandre.lureau
2020-11-26 12:09 ` Peter Maydell
2020-12-01 21:53 ` Stefano Stabellini
2020-11-26 11:29 ` [PATCH v2 12/13] compiler: " marcandre.lureau
2020-11-26 12:10 ` Peter Maydell
2020-11-26 12:12 ` Marc-André Lureau
2020-11-26 11:29 ` [PATCH v2 13/13] linux-user: " marcandre.lureau
2020-11-26 12:10 ` Peter Maydell
2020-11-26 11:57 ` [PATCH v2 00/13] Remove GCC < 4.8 checks no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7pcgt21.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).