From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
Cc: kwolf@redhat.com, wrampazz@redhat.com, ehabkost@redhat.com,
mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com,
mreitz@redhat.com, philmd@redhat.com, zhiwei_liu@c-sky.com,
rth@twiddle.net
Subject: Re: [PATCH v3 05/15] iotests: update snapshot test for new output format
Date: Mon, 07 Sep 2020 17:00:39 +0100 [thread overview]
Message-ID: <87h7s9r2zc.fsf@linaro.org> (raw)
In-Reply-To: <1afbeab2-e363-9be3-a751-2692263e80d2@ispras.ru>
Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru> writes:
> On 07.09.2020 18:26, Alex Bennée wrote:
>>
>> Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru> writes:
>>
>>> From: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>
>>>
>>> This patch updates iotests that verify qemu monitor output.
>>> New output format for snapshot listing include ICOUNT column.
>>
>> I was curious if the monitor should still function during replay. In my
>> setup:
>>
>> ./qemu-system-aarch64 -cpu cortex-a53 -display none -serial mon:stdio -machine virt -kernel zephyr.elf -net none -icount shift=6,align=off,sleep=off,rr=replay,rrfile=record.out -drive file=record.qcow2,if=none,snapshot,id=rr -s -S
>> *** Booting Zephyr OS build zephyr-v2.3.0-1183-ge5628ad0faf3 ***
>> Hello World! qemu_cortex_a53
>> qemu-system-aarch64: Missing character write event in the replay log
>
> And what about -monitor stdio instead of -serial mon:stdio?
Well I switched to:
-monitor telnet:127.0.0.1:4444
and controlled that way. I appreciate having a multiplexed
serial/monitor is a tricky edge case but I'm curious as to why it broke.
>
>>
>> although technically the C-a shouldn't be a character that ever makes it
>> to the guest.
>>
>>>
>>> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
>>> ---
>>> tests/qemu-iotests/267.out | 48 ++++++++++++++++++++++----------------------
>>> 1 file changed, 24 insertions(+), 24 deletions(-)
>>>
>>> diff --git a/tests/qemu-iotests/267.out b/tests/qemu-iotests/267.out
>>> index 215902b3ad..27471ffae8 100644
>>> --- a/tests/qemu-iotests/267.out
>>> +++ b/tests/qemu-iotests/267.out
>>> @@ -33,8 +33,8 @@ QEMU X.Y.Z monitor - type 'help' for more information
>>> (qemu) savevm snap0
>>> (qemu) info snapshots
>>> List of snapshots present on all disks:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> --- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> (qemu) loadvm snap0
>>> (qemu) quit
>>>
>>> @@ -44,8 +44,8 @@ QEMU X.Y.Z monitor - type 'help' for more information
>>> (qemu) savevm snap0
>>> (qemu) info snapshots
>>> List of snapshots present on all disks:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> --- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> (qemu) loadvm snap0
>>> (qemu) quit
>>>
>>> @@ -69,8 +69,8 @@ QEMU X.Y.Z monitor - type 'help' for more information
>>> (qemu) savevm snap0
>>> (qemu) info snapshots
>>> List of snapshots present on all disks:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> --- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> (qemu) loadvm snap0
>>> (qemu) quit
>>>
>>> @@ -94,8 +94,8 @@ QEMU X.Y.Z monitor - type 'help' for more information
>>> (qemu) savevm snap0
>>> (qemu) info snapshots
>>> List of snapshots present on all disks:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> --- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> (qemu) loadvm snap0
>>> (qemu) quit
>>>
>>> @@ -105,8 +105,8 @@ QEMU X.Y.Z monitor - type 'help' for more information
>>> (qemu) savevm snap0
>>> (qemu) info snapshots
>>> List of snapshots present on all disks:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> --- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> (qemu) loadvm snap0
>>> (qemu) quit
>>>
>>> @@ -119,8 +119,8 @@ QEMU X.Y.Z monitor - type 'help' for more information
>>> (qemu) savevm snap0
>>> (qemu) info snapshots
>>> List of snapshots present on all disks:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> --- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> (qemu) loadvm snap0
>>> (qemu) quit
>>>
>>> @@ -134,8 +134,8 @@ QEMU X.Y.Z monitor - type 'help' for more information
>>> (qemu) savevm snap0
>>> (qemu) info snapshots
>>> List of snapshots present on all disks:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> --- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> (qemu) loadvm snap0
>>> (qemu) quit
>>>
>>> @@ -145,15 +145,15 @@ QEMU X.Y.Z monitor - type 'help' for more information
>>> (qemu) savevm snap0
>>> (qemu) info snapshots
>>> List of snapshots present on all disks:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> --- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> (qemu) loadvm snap0
>>> (qemu) quit
>>>
>>> Internal snapshots on overlay:
>>> Snapshot list:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> -1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> Internal snapshots on backing file:
>>>
>>> === -blockdev with NBD server on the backing file ===
>>> @@ -166,17 +166,17 @@ QEMU X.Y.Z monitor - type 'help' for more information
>>> (qemu) savevm snap0
>>> (qemu) info snapshots
>>> List of snapshots present on all disks:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> --- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> (qemu) loadvm snap0
>>> (qemu) quit
>>>
>>> Internal snapshots on overlay:
>>> Snapshot list:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> -1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> Internal snapshots on backing file:
>>> Snapshot list:
>>> -ID TAG VM SIZE DATE VM CLOCK
>>> -1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> +ID TAG VM SIZE DATE VM CLOCK ICOUNT
>>> +1 snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
>>> *** done
>>
>>
--
Alex Bennée
next prev parent reply other threads:[~2020-09-07 16:03 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 8:15 [PATCH v3 00/15] Reverse debugging Pavel Dovgalyuk
2020-09-02 8:15 ` [PATCH v3 01/15] replay: don't record interrupt poll Pavel Dovgalyuk
2020-09-07 10:17 ` Alex Bennée
2020-09-02 8:15 ` [PATCH v3 02/15] replay: provide an accessor for rr filename Pavel Dovgalyuk
2020-09-02 8:16 ` [PATCH v3 03/15] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2020-09-02 8:16 ` [PATCH v3 04/15] migration: " Pavel Dovgalyuk
2020-09-02 8:16 ` [PATCH v3 05/15] iotests: update snapshot test for new output format Pavel Dovgalyuk
2020-09-07 15:26 ` Alex Bennée
2020-09-07 15:41 ` Pavel Dovgalyuk
2020-09-07 16:00 ` Alex Bennée [this message]
2020-09-07 16:05 ` Pavel Dovgalyuk
2020-09-08 13:10 ` Eric Blake
2020-09-02 8:16 ` [PATCH v3 06/15] qapi: introduce replay.json for record/replay-related stuff Pavel Dovgalyuk
2020-09-02 8:16 ` [PATCH v3 07/15] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2020-09-02 8:16 ` [PATCH v3 08/15] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2020-09-02 8:16 ` [PATCH v3 09/15] replay: implement replay-seek command Pavel Dovgalyuk
2020-09-07 12:45 ` Alex Bennée
2020-09-07 13:32 ` Pavel Dovgalyuk
2020-09-07 12:58 ` Alex Bennée
2020-09-07 13:27 ` Pavel Dovgalyuk
2020-09-07 14:59 ` Alex Bennée
2020-09-07 15:46 ` Pavel Dovgalyuk
2020-09-07 16:25 ` Alex Bennée
2020-09-08 7:44 ` Pavel Dovgalyuk
2020-09-08 9:13 ` Alex Bennée
2020-09-08 10:57 ` Pavel Dovgalyuk
2020-09-08 11:10 ` Alex Bennée
2020-09-08 12:15 ` Pavel Dovgalyuk
2020-09-08 10:54 ` Pavel Dovgalyuk
2020-09-02 8:16 ` [PATCH v3 10/15] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2020-09-07 13:37 ` Alex Bennée
2020-09-02 8:16 ` [PATCH v3 11/15] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2020-09-07 16:30 ` Alex Bennée
2020-09-08 11:16 ` Alex Bennée
2020-09-02 8:16 ` [PATCH v3 12/15] gdbstub: add reverse continue " Pavel Dovgalyuk
2020-09-02 8:17 ` [PATCH v3 13/15] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2020-09-08 11:27 ` Alex Bennée
2020-09-08 12:57 ` Pavel Dovgalyuk
2020-09-02 8:17 ` [PATCH v3 14/15] tests: bump avocado version Pavel Dovgalyuk
2020-09-02 17:02 ` Willian Rampazzo
2020-09-04 21:39 ` Cleber Rosa
2020-09-02 8:17 ` [PATCH v3 15/15] tests/acceptance: add reverse debugging test Pavel Dovgalyuk
2020-09-08 13:01 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7s9r2zc.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=wrampazz@redhat.com \
--cc=zhiwei_liu@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).