From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH 05/12] migration: Move colo.h to migration/
Date: Mon, 15 May 2017 13:04:36 +0200 [thread overview]
Message-ID: <87h90mfkjf.fsf@secure.mitica> (raw)
In-Reply-To: <20170512175105.GI2069@work-vm> (David Alan Gilbert's message of "Fri, 12 May 2017 18:51:06 +0100")
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
D> * Juan Quintela (quintela@redhat.com) wrote:
>> There are functions only used by migration code.
>
> That's only mostly true; see the current 'integrate colo frame with
> block replication and net compare' series (posted 22nd April).
> That adds colo_handle_shutdown to this header and calls it from vl.c
> ( https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg03901.html )
> where should that go?
Dropped.
It compiled, but who knows O:-)
> There's also a net/colo.h as well, so using the
> #include "colo.h" in migration is correct but that's
> really scary when there are two files of the same name.
Yeap, it is scary ...
next prev parent reply other threads:[~2017-05-15 11:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 16:00 [Qemu-devel] [PATCH v3 00/12] Migration mini-cleanup Juan Quintela
2017-05-12 16:00 ` [Qemu-devel] [PATCH 01/12] migration: Create migration/xbzrle.h Juan Quintela
2017-05-12 16:00 ` [Qemu-devel] [PATCH 02/12] migration: Split migration/channel.c for channel operations Juan Quintela
2017-05-12 16:00 ` [Qemu-devel] [PATCH 03/12] migration: Export qemu-file-channel.c functions in its own file Juan Quintela
2017-05-12 16:00 ` [Qemu-devel] [PATCH 04/12] migration: Remove migration.h from colo.h Juan Quintela
2017-05-12 16:00 ` [Qemu-devel] [PATCH 05/12] migration: Move colo.h to migration/ Juan Quintela
2017-05-12 17:51 ` Dr. David Alan Gilbert
2017-05-15 11:04 ` Juan Quintela [this message]
2017-05-15 12:44 ` Hailiang Zhang
2017-05-12 16:00 ` [Qemu-devel] [PATCH 06/12] migration: Move failover.h to migration/colo-failover.h Juan Quintela
2017-05-12 16:00 ` [Qemu-devel] [PATCH 07/12] migration: Move page_cache.c to migration/ Juan Quintela
2017-05-12 16:00 ` [Qemu-devel] [PATCH 08/12] migration: Move qjson.h " Juan Quintela
2017-05-12 16:00 ` [Qemu-devel] [PATCH 09/12] migration: Split vmstate-types.c from vmstate.c Juan Quintela
2017-05-12 17:54 ` Dr. David Alan Gilbert
2017-05-15 11:05 ` Juan Quintela
2017-05-12 16:00 ` [Qemu-devel] [PATCH 10/12] migration: Remove qemu-file.h from vmstate.h Juan Quintela
2017-05-12 16:00 ` [Qemu-devel] [PATCH 11/12] migration: Remove vmstate.h from migration.h Juan Quintela
2017-05-13 21:09 ` Philippe Mathieu-Daudé
2017-05-12 16:00 ` [Qemu-devel] [PATCH 12/12] migration: migration.h was not needed Juan Quintela
2017-05-12 17:58 ` Dr. David Alan Gilbert
2017-05-15 11:10 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h90mfkjf.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).