From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwtnI-0000Yo-Lt for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:28:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwtnE-00055O-Ex for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:28:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwtnE-00055J-98 for qemu-devel@nongnu.org; Thu, 12 Nov 2015 10:28:08 -0500 From: Juan Quintela In-Reply-To: <1447340003-12265-1-git-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Thu, 12 Nov 2015 16:53:48 +0200") References: <1447340003-12265-1-git-send-email-mst@redhat.com> Date: Thu, 12 Nov 2015 16:28:02 +0100 Message-ID: <87h9krqltp.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] migration/ram: fix build on 32 bit hosts Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Amit Shah , Peter Maydell , qemu-devel@nongnu.org, dgilbert@redhat.com "Michael S. Tsirkin" wrote: > ram_addr_t must be printed with RAM_ADDR_FMT not %z. > Also, change size print to %zx to match what RAM_ADDR_FMT does. > > Signed-off-by: Michael S. Tsirkin Equivalent patch on queue and will be send with another couple of fixes later Today. Thanks. > --- > migration/ram.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 62cf42b..80a67bb 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -1184,7 +1184,7 @@ int ram_save_queue_pages(MigrationState *ms, const char *rbname, > } > trace_ram_save_queue_pages(ramblock->idstr, start, len); > if (start+len > ramblock->used_length) { > - error_report("%s request overrun start=%zx len=%zx blocklen=%zx", > + error_report("%s request overrun start=0x" RAM_ADDR_FMT " len=0x" RAM_ADDR_FMT " blocklen=0x" RAM_ADDR_FMT, > __func__, start, len, ramblock->used_length); > goto err; > } > @@ -1845,7 +1845,7 @@ int ram_discard_range(MigrationIncomingState *mis, > ret = postcopy_ram_discard_range(mis, host_startaddr, length); > } else { > error_report("ram_discard_range: Overrun block '%s' (%" PRIu64 > - "/%zu/%zu)", > + "/%zx/0x" RAM_ADDR_FMT ")", > block_name, start, length, rb->used_length); > }