From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYyfQ-0002Q7-Pf for qemu-devel@nongnu.org; Mon, 07 Sep 2015 11:49:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYyfN-0000vd-Do for qemu-devel@nongnu.org; Mon, 07 Sep 2015 11:49:12 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:37736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYyfN-0000vZ-7e for qemu-devel@nongnu.org; Mon, 07 Sep 2015 11:49:09 -0400 Received: by wicfx3 with SMTP id fx3so88034505wic.0 for ; Mon, 07 Sep 2015 08:49:08 -0700 (PDT) References: <1440375847-17603-1-git-send-email-cota@braap.org> <1440375847-17603-3-git-send-email-cota@braap.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1440375847-17603-3-git-send-email-cota@braap.org> Date: Mon, 07 Sep 2015 16:49:07 +0100 Message-ID: <87h9n69qmk.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC 02/38] hw/i386/kvmvapic: add missing include of tcg.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" Cc: mttcg@listserver.greensocs.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, guillaume.delbergue@greensocs.com, pbonzini@redhat.com, Frederic Konrad Emilio G. Cota writes: > So that the declaration of tb_lock can be found. OK this confused me somewhat as exposing TCG details to the hardware emulation seems broken. However I notice the code your adding to isn't in Fred's latest series although the tb_gen_code ugliness is in master so will need addressing. I'm not sure why x86 is the special snowflake in this case. It looks like a performance hack for emulation which I guess the other guests don't do. > > Signed-off-by: Emilio G. Cota > --- > hw/i386/kvmvapic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c > index 1c3b5b6..a9a33fd 100644 > --- a/hw/i386/kvmvapic.c > +++ b/hw/i386/kvmvapic.c > @@ -13,6 +13,7 @@ > #include "sysemu/kvm.h" > #include "hw/i386/apic_internal.h" > #include "hw/sysbus.h" > +#include "tcg/tcg.h" > > #define VAPIC_IO_PORT 0x7e -- Alex Bennée