From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCUWg-0002Na-8p for qemu-devel@nongnu.org; Tue, 07 Jul 2015 11:11:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCUWc-0007Wy-Cy for qemu-devel@nongnu.org; Tue, 07 Jul 2015 11:11:14 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:33464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCUWb-0007Wo-Vq for qemu-devel@nongnu.org; Tue, 07 Jul 2015 11:11:10 -0400 Received: by wgck11 with SMTP id k11so170973061wgc.0 for ; Tue, 07 Jul 2015 08:11:09 -0700 (PDT) References: <1435330053-18733-1-git-send-email-fred.konrad@greensocs.com> <1435330053-18733-12-git-send-email-fred.konrad@greensocs.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1435330053-18733-12-git-send-email-fred.konrad@greensocs.com> Date: Tue, 07 Jul 2015 16:11:06 +0100 Message-ID: <87h9pg9f5h.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH V6 11/18] cpus: make qemu_cpu_kick_thread public. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, a.spyridakis@virtualopensystems.com, mark.burton@greensocs.com, agraf@suse.de, qemu-devel@nongnu.org, guillaume.delbergue@greensocs.com, pbonzini@redhat.com, alistair.francis@xilinx.com fred.konrad@greensocs.com writes: > From: KONRAD Frederic > > This makes qemu_cpu_kick_thread public. > > Signed-off-by: KONRAD Frederic > --- > cpus.c | 2 +- > include/sysemu/cpus.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/cpus.c b/cpus.c > index 08267ed..5f13d73 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -1067,7 +1067,7 @@ static void *qemu_tcg_cpu_thread_fn(void *arg) > return NULL; > } > > -static void qemu_cpu_kick_thread(CPUState *cpu) > +void qemu_cpu_kick_thread(CPUState *cpu) > { > #ifndef _WIN32 > int err; > diff --git a/include/sysemu/cpus.h b/include/sysemu/cpus.h > index 3f162a9..4f95b72 100644 > --- a/include/sysemu/cpus.h > +++ b/include/sysemu/cpus.h > @@ -6,6 +6,7 @@ void qemu_init_cpu_loop(void); > void resume_all_vcpus(void); > void pause_all_vcpus(void); > void cpu_stop_current(void); > +void qemu_cpu_kick_thread(CPUState *cpu); Again I couldn't see use outside of cpus.c which could be solved by putting the declaration at the top. > > void cpu_synchronize_all_states(void); > void cpu_synchronize_all_post_reset(void); -- Alex Bennée