From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVO1I-0003Yx-RJ for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:32:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVO1F-0003qh-W3 for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:32:40 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:55737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVO1F-0003j9-Bh for qemu-devel@nongnu.org; Tue, 10 Mar 2015 13:32:37 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 11 Mar 2015 03:32:34 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id F16D02BB0040 for ; Wed, 11 Mar 2015 04:32:31 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2AHWNtq46137470 for ; Wed, 11 Mar 2015 04:32:31 +1100 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2AHVwjj017322 for ; Wed, 11 Mar 2015 04:31:58 +1100 From: "Aneesh Kumar K.V" In-Reply-To: <54FE70D8.2010904@msgid.tls.msk.ru> References: <1425633831-3101-1-git-send-email-mjt@tls.msk.ru> <1425633831-3101-2-git-send-email-mjt@msgid.tls.msk.ru> <87385f4f5v.fsf@linux.vnet.ibm.com> <54FE70D8.2010904@msgid.tls.msk.ru> Date: Tue, 10 Mar 2015 23:01:40 +0530 Message-ID: <87h9tsrc77.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-devel@nongnu.org Michael Tokarev writes: > 08.03.2015 19:39, Aneesh Kumar K.V wrote: >> Michael Tokarev writes: >> >>> This simplifies code in v9fs_request() a bit by replacing several >>> ifs with a common variable check and rearranging error/cleanup >>> code a bit. >> >> Is this -V2 of >> http://mid.gmane.org/b98f675750ef0535cab41225240db1657fc2fe00.1425678142.git.mjt@msgid.tls.msk.ru > > No, this one (simplify v9fs_reqeust(), P1) was a first version. > The above URL points to the v2, a second version. Please post an update patch series with the variable rename and the v9fs simplification as two different patches. > >> I am slightly confused with the patch series. It does split the patch as >> I wanted, but i am not sure which one is the latest, so that i can start >> applying them. > > That URL points to last. I merged several small patches into larger ones. > > Initially I thought I just plug a small resource leak so the patch will > be small. But the more I understood the code, the bigger the changes > were becoming. So at some point it become unreasonable to keep small > changes since they're related to bigger changes and since bigger changes > touches the same code anyway. > Please keep the patches smaller. If needed i can fold them up when merging the changes. -aneesh