qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache()
Date: Tue, 11 Mar 2014 12:36:55 +0100	[thread overview]
Message-ID: <87ha757yqw.fsf@elfo.mitica> (raw)
In-Reply-To: <1394531919-14346-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Tue, 11 Mar 2014 10:58:39 +0100")

Kevin Wolf <kwolf@redhat.com> wrote:
> After migration has completed, we call bdrv_invalidate_cache() so that
> drivers which cache some data drop their stale copy of the data and
> reread it from the image file to get a new version of data that the
> source modified while the migration was running.
>
> Reloading metadata from the image file is useless, though, if the size
> of the image file stays stale (this is a value that is cached for all
> image formats in block.c). Reads from (meta)data after the old EOF
> return only zeroes, causing image corruption.
>
> We need to update bs->total_sectors in all layers that could potentially
> have changed their size (i.e. backing files are not a concern - if they
> are changed, we're in bigger trouble)
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>
Tested-by: Juan Quintela <quintela@redhat.com>

I had problems with migration with qcow2 files, and this fixes it.

  reply	other threads:[~2014-03-11 11:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11  9:58 [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache() Kevin Wolf
2014-03-11 11:36 ` Juan Quintela [this message]
2014-03-11 12:47 ` Stefan Hajnoczi
2014-03-11 16:41 ` Benoît Canet
2014-03-12  9:40   ` Kevin Wolf
2014-03-12  9:43     ` Benoît Canet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ha757yqw.fsf@elfo.mitica \
    --to=quintela@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).