From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, "Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build
Date: Thu, 06 Mar 2014 11:01:54 +0530 [thread overview]
Message-ID: <87ha7bc2ph.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <5317716F.8040606@suse.de>
Andreas Färber <afaerber@suse.de> writes:
> Am 04.03.2014 00:36, schrieb Serge E. Hallyn:
>> Quoting Aneesh Kumar K.V (aneesh.kumar@linux.vnet.ibm.com):
>>> commit 01041f5df94ff19988cbadd7bd3eefcc9d964e4e
>>> Author: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>>> Date: Tue Mar 4 00:35:32 2014 +0530
>>>
>>> hw/9pfs: Include virtio-9p-device.o in build
>>>
>>> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including
>>> hw/Makefile.objs directly from Makefile.target. Make sure hw/Makefile.objs
>>> rules doesn't depend on variable defined in Makefile.objs
>>>
>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>>
>> Thanks, Aneesh, this worked for me.
>>
>> Tested-by: Serge Hallyn <serge.hallyn@ubuntu.com>
>
> Tested-by: Andreas Färber <afaerber@suse.de>
>
> Aneesh, could you please either properly submit a v2 so that Peter can
> apply it or send a pull to somehow fix this?
Will do a pull request with this and others by end of week.
The tree with patches are already here
https://github.com/kvaneesh/qemu/commits/for-upstream
Just need to get one more round of testing.
-aneesh
next prev parent reply other threads:[~2014-03-06 5:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 19:08 [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build Aneesh Kumar K.V
2014-03-03 19:13 ` Paolo Bonzini
2014-03-03 19:42 ` Aneesh Kumar K.V
2014-03-03 20:02 ` Aneesh Kumar K.V
2014-03-03 20:32 ` Aneesh Kumar K.V
2014-03-03 23:36 ` Serge E. Hallyn
2014-03-05 18:48 ` Andreas Färber
2014-03-06 5:31 ` Aneesh Kumar K.V [this message]
2014-03-03 23:45 ` Peter Maydell
2014-03-05 15:50 ` Andreas Färber
2014-03-05 18:19 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha7bc2ph.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).