From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLQuv-0003fp-W1 for qemu-devel@nongnu.org; Thu, 06 Mar 2014 00:32:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLQup-0005C5-MF for qemu-devel@nongnu.org; Thu, 06 Mar 2014 00:32:25 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:43959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLQuo-0005Bd-Tc for qemu-devel@nongnu.org; Thu, 06 Mar 2014 00:32:19 -0500 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 6 Mar 2014 15:32:13 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 004F02CE8055 for ; Thu, 6 Mar 2014 16:32:07 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s265VrNj8716786 for ; Thu, 6 Mar 2014 16:31:54 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s265W6go019079 for ; Thu, 6 Mar 2014 16:32:06 +1100 From: "Aneesh Kumar K.V" In-Reply-To: <5317716F.8040606@suse.de> References: <1393873716-9574-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <5314D475.8070107@redhat.com> <87r46jvx99.fsf@linux.vnet.ibm.com> <20140303233652.GA12334@mail.hallyn.com> <5317716F.8040606@suse.de> Date: Thu, 06 Mar 2014 11:01:54 +0530 Message-ID: <87ha7bc2ph.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Peter Maydell , Paolo Bonzini , Fam Zheng , qemu-devel@nongnu.org, "Serge E. Hallyn" Andreas F=C3=A4rber writes: > Am 04.03.2014 00:36, schrieb Serge E. Hallyn: >> Quoting Aneesh Kumar K.V (aneesh.kumar@linux.vnet.ibm.com): >>> commit 01041f5df94ff19988cbadd7bd3eefcc9d964e4e >>> Author: Aneesh Kumar K.V >>> Date: Tue Mar 4 00:35:32 2014 +0530 >>> >>> hw/9pfs: Include virtio-9p-device.o in build >>>=20=20=20=20=20 >>> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are includ= ing >>> hw/Makefile.objs directly from Makefile.target. Make sure hw/Makefi= le.objs >>> rules doesn't depend on variable defined in Makefile.objs >>>=20=20=20=20=20 >>> Signed-off-by: Aneesh Kumar K.V >>=20 >> Thanks, Aneesh, this worked for me. >>=20 >> Tested-by: Serge Hallyn > > Tested-by: Andreas F=C3=A4rber > > Aneesh, could you please either properly submit a v2 so that Peter can > apply it or send a pull to somehow fix this? Will do a pull request with this and others by end of week. The tree with patches are already here https://github.com/kvaneesh/qemu/commits/for-upstream Just need to get one more round of testing. -aneesh