From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtLI4-0003hw-T0 for qemu-devel@nongnu.org; Wed, 18 Dec 2013 12:52:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtLHw-0000fw-UQ for qemu-devel@nongnu.org; Wed, 18 Dec 2013 12:52:12 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:49234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtLHw-0000fQ-3E for qemu-devel@nongnu.org; Wed, 18 Dec 2013 12:52:04 -0500 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Dec 2013 03:52:00 +1000 From: "Aneesh Kumar K.V" In-Reply-To: <7E9EE0FC-EFAC-4DBB-8BB4-B59510713E19@suse.de> References: <1383834423-11719-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <7E9EE0FC-EFAC-4DBB-8BB4-B59510713E19@suse.de> Date: Wed, 18 Dec 2013 23:21:53 +0530 Message-ID: <87haa69hdy.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH -V2] kvm: Add a new machine property kvm_type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "qemu-ppc@nongnu.org list:PowerPC" , Paul Mackerras , QEMU Developers , Paolo Bonzini Alexander Graf writes: > On 07.11.2013, at 15:27, Aneesh Kumar K.V wrote: > >> From: "Aneesh Kumar K.V" >> diff --git a/hw/ppc/e500plat.c b/hw/ppc/e500plat.c >> index 2e964b2..4be4b24 100644 >> --- a/hw/ppc/e500plat.c >> +++ b/hw/ppc/e500plat.c >> @@ -17,6 +17,7 @@ >> #include "hw/pci/pci.h" >> #include "hw/ppc/openpic.h" >> #include "kvm_ppc.h" >> +#include "kvmtype.h" >> >> static void e500plat_fixup_devtree(PPCE500Params *params, void *fdt) >> { >> @@ -51,6 +52,7 @@ static QEMUMachine e500plat_machine = { >> .desc = "generic paravirt e500 platform", >> .init = e500plat_init, >> .max_cpus = 32, >> + .kvm_type = pr_kvm_type, > > What about mpc8544ds? Also, e500plat can definitely support HV > (e500mc+) and PR (e500v2) mode. So you probably want the same check > here as you have in spapr. I don't have access to the hardware to validate. So at this point, I would suggest we change the code such that we don't change the functionality. > > Unfortunately the patch doesn't apply anymore. Would you care to > rebase it? I think it's also more targeted towards the kvm queue > rather than the ppc queue, so I'd either like an ack from Paolo or > would defer to his tree for inclusion :). Will resend -aneesh